Java LS should lock its workspace #1010
Conversation
There was a problem hiding this comment.
I could only test it in vscode by inverting the lock check condition. So when it fails, vscode shows no log message (you need to manually open the workspace .log file) and the only user feedback is the server failed to start 5 times.
@snjeza if the server actually crashes, what are the chances the lock survives after a restart?
Can someone from the Che team test this PR? cc @tsmaeder , @tolusha
| if (workspaceFile.exists()) { | ||
| JavaLanguageServerPlugin.logError("Could not launch the server because associated workspace is currently in use by another Java LS server."); | ||
| } | ||
| return IApplication.EXIT_OK; |
There was a problem hiding this comment.
You should return a Not-OK code instead
| if (!instanceLoc.lock()) { | ||
| File workspaceFile = new File(instanceLoc.getURL().getFile()); | ||
| if (workspaceFile.exists()) { | ||
| JavaLanguageServerPlugin.logError("Could not launch the server because associated workspace is currently in use by another Java LS server."); |
There was a problem hiding this comment.
at that point there's no connection established so no message can surface to the client
There was a problem hiding this comment.
We can only use the standard Eclipse log (/.metadata/.log)
| File workspaceFile = new File(instanceLoc.getURL().getFile()); | ||
| if (workspaceFile.exists()) { | ||
| JavaLanguageServerPlugin.logError("Could not launch the server because associated workspace is currently in use by another Java LS server."); | ||
| } |
There was a problem hiding this comment.
if workspaceFile doesn't exist we don't log anything???
There was a problem hiding this comment.
You can try add the following property:
java.jdt.ls.vmargs": "-Djdt.ls.debug=true...",
There was a problem hiding this comment.
my point is you have a workflow branch where the server would exit without logging anything whatsoever. Makes it harder to troubleshoot
|
test this please |
| if (workspaceFile.exists()) { | ||
| JavaLanguageServerPlugin.logError("Could not launch the server because associated workspace is currently in use by another Java LS server."); | ||
| } | ||
| return new Integer(1); |
Signed-off-by: Snjezana Peco <[email protected]>
|
So what happens with multiple tabs on the same in Che workspace, when that PR is applied? |
|
Only one Java LS will be started. Che 7 will receive an error message. |
Can you provide a screenshot? I'm curious to see that. |
I will try. |
As with Theia itself, you can open multiple windows into the same back end. But that's not the worst: if you restart the language server (by changing the vm options in the preferences, for example), the old processes seem to coexist with the new ones, so I suspect this is a real problem. While refusing to work on a locked workspace is probably the correct thing to do when looking only at jdt.ls, this will probably break stuff. |
You can try the "Duplicate Workspace in New Window" command. It will start two Java LS servers with different Java LS workspaces. |
Fixes #978
Signed-off-by: Snjezana Peco [email protected]