Reopening a gradle project resets its gradle version

[snjeza]

Fixes redhat-developer/vscode-java#924

Signed-off-by: Snjezana Peco [email protected]

[snjeza]

test this please

[snjeza]

The issue can be reproduced in Eclipse too. I have created a workaround.

[fbricon]

So I'm a bit worried that we're setting the gradleHome attribute (as found in the environment variable) to something that doesn't match the gradle version (set by java.import.gradle.version). It doesn't seem to break anything so far but it certainly doesn't feel right

[fbricon]

Checked with Eclipse/Buildship, when a project uses a specific Gradle version or the wrapper, neither gradle.user.home nor java.home are set:

arguments=
auto.sync=false
build.scans.enabled=false
connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(5.1.1))
connection.project.dir=
eclipse.preferences.version=1
gradle.user.home=
java.home=
jvm.arguments=
offline.mode=false
override.workspace.settings=true
show.console.view=false
show.executions.view=false

or

arguments=
auto.sync=false
build.scans.enabled=false
connection.gradle.distribution=GRADLE_DISTRIBUTION(WRAPPER)
connection.project.dir=
eclipse.preferences.version=1
gradle.user.home=
java.home=
jvm.arguments=
offline.mode=false
override.workspace.settings=true
show.console.view=false
show.executions.view=false

Also, it seems the current patch is losing current buildship settings informations. E.g if auto.sync was set to true initially, it's lost. I think the fix should 1st load the buildship settings if they exist, then override their values if necessary and finally save them.

[fbricon]

It doesn't seem to work with buildship 3.1. With a project created in eclipse, overriding workspace default to enable autosync, the buildship core prefs looks like:

arguments=
auto.sync=true
build.scans.enabled=false
connection.gradle.distribution=GRADLE_DISTRIBUTION(WRAPPER)
connection.project.dir=
eclipse.preferences.version=1
gradle.user.home=
java.home=
jvm.arguments=
offline.mode=false
override.workspace.settings=true
show.console.view=false
show.executions.view=false

When importing the project in vscode, the new content becomes:

connection.project.dir=
eclipse.preferences.version=1

[fbricon]

I still lose the buildship settings when importing the project in a clean workspace :-/

[snjeza]

@fbricon I have updated the PR.

[fbricon]

Can you please rebase?

[snjeza]

@fbricon I have rebased the PR.