Implement methods in newly created type from an inherited sealed class. #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Creates a new class as you type 😂 |
|
... and the generated classes don't even implement the interface method :-) |
|
😂 thanks for verifying in IDE. I think what's happening is the main issue I had from before. The creation of the problem marker, causes the associated text edit to also be created. In our case, the text edit immediately creates the type. I'll see what I can do. |
- When a non-existent type is permitted by a sealed class, the newly created type should implement the necessary methods - Related eclipse-jdtls#1553 Signed-off-by: Roland Grunberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created type should implement the necessary methods
.. turns out it's possible after all. Still need to clean it up a bit though.