Pass the projects manager to the telemetry manager in a safer manner.

[rgrunber]

• Fixes An internal error occurred during: "Initialize workspace" #2842

[testforstephen]

Should we add a property in TelemetryManager to indicate whether the project importer gets any errors or not?

[rgrunber]

I could add it here to be part of the communication back through telemetry/event but I noticed we do send a notification to the client of the error at

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/InitHandler.java

Line 270 in ff0190c

connection.sendStatus(ServiceStatus.Error, e.getMessage());

.

As an example, vscode-java, takes advantage of this via. https://github.com/redhat-developer/vscode-java/blob/65cd8812a07a7fab26a924aa4bc20c4f5d894996/src/standardLanguageClient.ts#L164-L174 .

If you still want this, I can add the error to the telemetry event here.

[testforstephen]

We have other ways to get the import failure, it's ok. When project import aborts with exception, time.projectsinitialized would be negative because this.projectsInitializedTime is not set. We can tell it's an aborted importing from this value as well.

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java

Lines 147 to 159 in 847f305

	projectInitElapsedTime = this.projectsInitializedTime - this.languageServerStartTime;
	serviceReadyElapsedTime = this.serviceReadyTime - this.languageServerStartTime;
	buildFinishedElapsedTime = buildFinishedTime - this.languageServerStartTime;
	properties.add("buildToolNames", buildToolNamesList);
	properties.addProperty("javaProjectCount", javaProjectCount);
	if (sourceLevelMin != 0) {
	properties.addProperty("compiler.source.min", Float.toString(sourceLevelMin));
	}
	if (sourceLevelMax != 0) {
	properties.addProperty("compiler.source.max", Float.toString(sourceLevelMax));
	}
	properties.addProperty("time.projectsinitialized", Long.toString(projectInitElapsedTime));