Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null root in SemanticTokensHandler #2915

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Check for null root in SemanticTokensHandler #2915

merged 1 commit into from
Oct 20, 2023

Conversation

hopehadfield
Copy link
Contributor

Fixes #2876

@rgrunber rgrunber self-requested a review October 20, 2023 12:58
rgrunber
rgrunber approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's common practice in many places in the codebase to check whether CoreASTProvider.getInstance().getAST(....) returns null. This should do the same.

@rgrunber rgrunber merged commit 5cb8f7a into eclipse-jdtls:master Oct 20, 2023
4 checks passed
@hopehadfield hopehadfield deleted the 2876-npe branch October 20, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE in SemanticTokensHandler
2 participants
@hopehadfield @rgrunber