Build against jdt-core-incubator #2963

akurtakov · 2023-11-17T12:15:29Z

Changes to target platform are quite big as:

jdt feature can't be used

akurtakov · 2023-11-17T12:17:24Z

@rgrunber @fbricon This is an all in one commit for testing purposes . If there is an agreement I will split into multiple reviewable parts to we land them biggest part of it in master even without switching to use jdt-core-incubator for now.

rgrunber

Suppose there is a bug/feature that lands in the latest JDT Core upstream. Normally we would have picked it up by updating the qualifier portion of https://download.eclipse.org/eclipse/updates/4.30-I-builds/I20231030-1800/. How would we do this ? Is the latest incubator build guaranteed to match the latest version of jdt.core + incubation changes ? What if we want specifically to build against an older I-build and not the latest ?

akurtakov · 2023-11-17T13:52:59Z

Suppose there is a bug/feature that lands in the latest JDT Core upstream. Normally we would have picked it up by updating the qualifier portion of https://download.eclipse.org/eclipse/updates/4.30-I-builds/I20231030-1800/. How would we do this ?

Same way as till now - update the qualifier in the target platform. That would give you all updates in the I-build minus the jdt.core changes.

Is the latest incubator build guaranteed to match the latest version of jdt.core + incubation changes ?

No such guarantee. One has to rebase jdt-core-incubator:devel on top of https://github.com/eclipse-jdt/eclipse.jdt.core and push. After the push and successful build jdt-core-incubator p2 repo will contain latest version of jdt.core + incubation changes. I can imagine GH action to auto rebase on top of jdt.core master when clean rebase could happen, if it couldn't manual rebase would be needed.

What if we want specifically to build against an older I-build and not the latest ?

You can use older I-builds by changing the target platform but jdt-core-incubator will contain changes unless you rebase it to some commit too.

org.eclipse.jdt.ls.product/languageServer.product

laeubi · 2023-11-29T06:10:18Z

@akurtakov have you considered including the fragment as a maven dependency instead?

laeubi · 2023-11-29T06:14:49Z

by the way PDE now supports resolve between locations.

akurtakov · 2023-11-29T06:19:21Z

@akurtakov have you considered including the fragment as a maven dependency instead?

I would like to have it in sync with o.e.jdt.launching and same version as in the I-build. Publishing to Maven Central happens for releases only.

laeubi · 2024-01-10T07:26:22Z

thus jdt.launching.macos have to be included manually

By the way this should be fixed if this is merged:

Ensure that the mac os parts are installed together eclipse-jdt/eclipse.jdt.debug#211

laeubi · 2024-01-10T07:26:58Z

deps have to be moved to Maven as slicer can't resolve between locations

This should be fully supported by latest eclipse i-build now

akurtakov · 2024-01-10T07:30:24Z

deps have to be moved to Maven as slicer can't resolve between locations

This should be fully supported by latest eclipse i-build now

What about Tycho?

laeubi · 2024-01-10T07:33:56Z

deps have to be moved to Maven as slicer can't resolve between locations

This should be fully supported by latest eclipse i-build now

What about Tycho?

For Tycho this has worked from day 1 ...

akurtakov · 2024-01-12T09:11:21Z

@rgrunber this looks in good shape now. Is the failing test unstable?

rgrunber · 2024-01-12T14:11:27Z

retest this please.

Yes, that one has failed in the past also.

akurtakov · 2024-01-12T15:50:56Z

As soon as we have the first PR adding content that is not in jdt.core master this one should be merged. Aka make the incubatore effective.

rgrunber · 2024-01-24T21:55:29Z

org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target

            <unit id="org.mockito.mockito-core" version="0.0.0"/>
            <unit id="org.apache.commons.commons-io" version="0.0.0"/>
+            <unit id="org.eclipse.jdt.apt.pluggable.core" version="0.0.0" />


Is there a reason why jdt.apt.pluggable.core isn't being built by the incubator at https://github.com/eclipse-jdtls/eclipse-jdt-core-incubator/blob/develop/repository/category.xml ? Either way it's probably a good idea to make sure the incubator produces a snapshot build that matches the I-build from eclipse/updates.

Update: Might as well also remove the space between "0.0.0" and /> so it doesn't get autocorrected when loaded.

It build it but doesn't publish it . Do you want to publish it to downloads too? As I don't see any changes needed for any apt bundles I would even say it might be better to even not publish jdt.apt.core but use it from the I-build repo.

rgrunber · 2024-01-24T22:01:45Z

One nice side effect is this should reduce the target platform from ~344MB to ~244MB due to unnecessary artifacts that probably got dragged in due to features including too much.

rgrunber · 2024-01-29T19:00:10Z

...dt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/rename/RenameSupport.java

+					result.addAll(changeManager.getAllChanges());
+					String renamedCUName = JavaModelUtil.getRenamedCUName(type.getCompilationUnit(), getNewElementName());
+					result.add(new RenameCompilationUnitChange(type.getCompilationUnit(), renamedCUName));
+				} catch (CoreException e) {


We should probably log this, in case it happens so users at least have something in the log when nothing happens.

- Changes to target platform are quite big since jdt feature can't be used - Update target platform to latest 4.31 I-build (I20240128-1800). - [21] JEP 443 Unnamed patterns and variables - Adjust testcase due to fix for eclipse-jdt/eclipse.jdt.ui#1111 Co-authored-by: Александър Куртаков <[email protected]> Co-authored-by: Roland Grunberg <[email protected]>

rgrunber · 2024-01-29T21:36:50Z

Ok, this works well for me. I noticed one thing. Mainly that the repository/pom.xml for the incubator project lacks an <includeAllSources>true</includeAllSources>. It's needed to avoid the dreaded "Please attach sources" on the jdt.core bundle. I can fix that pretty easily though. In fact, it's probably easier to just duplicate the bundle IDs and add .source in the category.xml than to redefine the repository plugin and add the property.

Just fixed it at eclipse-jdtls/eclipse-jdt-core-incubator@9d8e609#diff-8ccc007f81194cc47a96ef7f50b7ade2d6964e99ae8c42bc4407bc42e82e808fR6 .

Update: Theeeere we are : https://download.eclipse.org/jdtls/jdt-core-incubator/snapshots/plugins/

akurtakov marked this pull request as draft November 17, 2023 12:15

akurtakov force-pushed the jdt-incubator-releng branch 2 times, most recently from 2dfb9f3 to 7687683 Compare November 17, 2023 12:53

rgrunber reviewed Nov 17, 2023

View reviewed changes

org.eclipse.jdt.ls.product/languageServer.product Outdated Show resolved Hide resolved

akurtakov mentioned this pull request Nov 17, 2023

Stop using Gson internal LinkedTreeMap in tests #2965

Merged

akurtakov force-pushed the jdt-incubator-releng branch 3 times, most recently from d23af22 to edc0211 Compare November 21, 2023 20:17

akurtakov force-pushed the jdt-incubator-releng branch 2 times, most recently from 5918b53 to c1ef01b Compare December 13, 2023 19:55

akurtakov force-pushed the jdt-incubator-releng branch from c1ef01b to c36120e Compare January 9, 2024 20:45

akurtakov force-pushed the jdt-incubator-releng branch 2 times, most recently from dbcfd91 to 2ba7d7a Compare January 11, 2024 16:38

rgrunber mentioned this pull request Jan 11, 2024

Update target platform to latest 4.31-I-build. #3020

Merged

akurtakov force-pushed the jdt-incubator-releng branch from 2ba7d7a to d4b42f7 Compare January 12, 2024 08:13

akurtakov marked this pull request as ready for review January 12, 2024 15:49

akurtakov force-pushed the jdt-incubator-releng branch from d4b42f7 to ebae67b Compare January 24, 2024 13:59

rgrunber reviewed Jan 24, 2024

View reviewed changes

rgrunber mentioned this pull request Jan 29, 2024

Update target platform to latest 4.31 I-build (I20240128-1800). #3035

Closed

rgrunber added this to the End January 2024 milestone Jan 29, 2024

rgrunber added the build/infra label Jan 29, 2024

rgrunber force-pushed the jdt-incubator-releng branch from ebae67b to afbe7db Compare January 29, 2024 18:14

rgrunber reviewed Jan 29, 2024

View reviewed changes

rgrunber force-pushed the jdt-incubator-releng branch from afbe7db to 8a1ace1 Compare January 29, 2024 21:13

rgrunber merged commit 1c05786 into eclipse-jdtls:master Jan 29, 2024
7 checks passed

rgrunber mentioned this pull request Mar 26, 2024

Fix tests failing to run on Mac #3113

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build against jdt-core-incubator #2963

Build against jdt-core-incubator #2963

akurtakov commented Nov 17, 2023 •

edited

Loading

akurtakov commented Nov 17, 2023

rgrunber left a comment

akurtakov commented Nov 17, 2023

laeubi commented Nov 29, 2023

laeubi commented Nov 29, 2023

akurtakov commented Nov 29, 2023

laeubi commented Jan 10, 2024

laeubi commented Jan 10, 2024

akurtakov commented Jan 10, 2024

laeubi commented Jan 10, 2024

akurtakov commented Jan 12, 2024

rgrunber commented Jan 12, 2024

akurtakov commented Jan 12, 2024

rgrunber Jan 24, 2024 •

edited

Loading

akurtakov Jan 25, 2024

rgrunber commented Jan 24, 2024 •

edited

Loading

rgrunber Jan 29, 2024

rgrunber commented Jan 29, 2024 •

edited

Loading

Build against jdt-core-incubator #2963

Build against jdt-core-incubator #2963

Conversation

akurtakov commented Nov 17, 2023 • edited Loading

akurtakov commented Nov 17, 2023

rgrunber left a comment

Choose a reason for hiding this comment

akurtakov commented Nov 17, 2023

laeubi commented Nov 29, 2023

laeubi commented Nov 29, 2023

akurtakov commented Nov 29, 2023

laeubi commented Jan 10, 2024

laeubi commented Jan 10, 2024

akurtakov commented Jan 10, 2024

laeubi commented Jan 10, 2024

akurtakov commented Jan 12, 2024

rgrunber commented Jan 12, 2024

akurtakov commented Jan 12, 2024

rgrunber Jan 24, 2024 • edited Loading

Choose a reason for hiding this comment

akurtakov Jan 25, 2024

Choose a reason for hiding this comment

rgrunber commented Jan 24, 2024 • edited Loading

rgrunber Jan 29, 2024

Choose a reason for hiding this comment

rgrunber commented Jan 29, 2024 • edited Loading

akurtakov commented Nov 17, 2023 •

edited

Loading

rgrunber Jan 24, 2024 •

edited

Loading

rgrunber commented Jan 24, 2024 •

edited

Loading

rgrunber commented Jan 29, 2024 •

edited

Loading