Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildship to 3.1.8 #2974

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Update buildship to 3.1.8 #2974

merged 1 commit into from
Nov 22, 2023

Conversation

akurtakov
Copy link
Contributor

No description provided.

@mickaelistria
Copy link
Contributor

So it looks like buildship release didn't go through IP checks?

@akurtakov
Copy link
Contributor Author

Not mandatory but could be. Dash tool sometimes doesn't recognize upstream artifacts when put in p2 repository.

@rgrunber
Copy link
Contributor

/request-license-review

Copy link

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-jdtls/eclipse.jdt.ls/actions/runs/6959202764

@donat
Copy link

donat commented Nov 22, 2023

This is the first Buildship release that is contributed via GitHub services. Also, please note that the project is built with Gradle and consequently does not use the Tycho build, which might be a problem for the GH checks.
Let me know if I can help resolving the licensing issue.

@akurtakov
Copy link
Contributor Author

So you should have a way to get a list of deps and then you should be able to use plain java -jar org.eclipse.dash.licenses-<version>.jar <dependency-list> as described at https://github.com/eclipse/dash-licenses/#usage .

@akurtakov
Copy link
Contributor Author

@rgrunber Any chance this is unstable test? I don't see the relation.

@rgrunber
Copy link
Contributor

retest this please.

Yeah, I think that test can fail sometimes.

@akurtakov
Copy link
Contributor Author

For the record as this test switches one dependency that is not in the iplab with another one and buildship guys say they have preapproval for that (eclipse-buildship/buildship#1263 (comment)) I think it should be fine .

@rgrunber rgrunber added this to the End November 2023 milestone Nov 22, 2023
@rgrunber
Copy link
Contributor

(It's ~3MB less when uncompressed)

45M jdt-ls-new/jdt-language-server-1.30.0-202311221719.tar.gz
47M jdt-ls-old/jdt-language-server-1.30.0-202311221718.tar.gz
plugins/com.google.guava_30.1.0.v20221112-0806.jar
plugins/org.eclipse.buildship.compat_3.1.7.v20221108-1729-s.jar
	plugins/org.eclipse.buildship.compat_3.1.8.v20231117-1658.jar
plugins/org.eclipse.buildship.core_3.1.7.v20221108-1729-s.jar
	plugins/org.eclipse.buildship.core_3.1.8.v20231117-1658.jar
plugins/org.gradle.toolingapi_7.4.2.v20220712-0930-s.jar
	plugins/org.gradle.toolingapi_8.1.1.v20231117-1658.jar

@rgrunber rgrunber merged commit 99d7f7b into eclipse-jdtls:master Nov 22, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants