Fix signature help for overloaded methods #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopehadfield
force-pushed
the
3052-signature-help
branch
2 times, most recently
from
8dc6fd8 to
ce2169c
Compare
|
Retest this please. |
|
It works for the case mentioned in #3052. Could you please add test cases as well? |
rgrunber
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Overall, looks fine. Just had to go remember what this piece of code was accomplishing, and I think there's a typo here.
Basically when items get collapsed we should always trigger signature help by ensuring the cursor is placed within the parameter area, and not outside. The replacement string containing the correct placeholder will do that.
...rc/org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalReplacementProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hope Hadfield <[email protected]>
hopehadfield
force-pushed
the
3052-signature-help
branch
from
15b4f1e to
e1f12d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3052
Signature help now displays all overloaded methods, though may now display some extra inapplicable methods in select cases. This also fixes an issue where signature help is not displayed for overloaded methods with no parameters, as the completion now places the cursor within the round brackets.