Fix license check workflow after repository move

[0dinD]

Currently, the licensecheck workflow is failing every time someone makes a push or even comments on an issue (I got an automated email from GitHub about it after posting a comment). It seems like this is caused by the Eclipse Dash License Tool repository being moved to a new organization, see eclipse-dash/dash-licenses#302 and in particular the last couple of comments on that issue. Basically, the GitHub workflow doesn't follow the redirect, so the workflow has to be updated to use the new repository in order for it to work again.

[0dinD]

Now that the license check actually ran for my PR, it seems like this has revealed that a license error has been masked for a while, because the license check failed again, this time with some more info: https://github.com/eclipse-jdtls/eclipse.jdt.ls/actions/runs/10694091002/job/29645306065?pr=3264

I'm not familiar with the Eclipse Dash License Tool, just thought I'd fix the issue preventing it from running. So I don't know what it's trying to tell me or how to fix it, and I don't have time to investigate right now. Some help with that would be appreciated. 🙂

[akurtakov]

/request-license-review

[0dinD]

Interesting to note that whereas the workflow that ran for my PR submission did use the updated YAML file from my branch, the one that ran for your comment did not. Looks like the ones that run for comments always use the YAML file from the master branch.

[akurtakov]

I'm merging this one to check whether request-license-review will work after that.

[0dinD]

I would assume it works now, as in, will run. The license check workflow ran successfully for the master branch (for the first time in a long while) after your merge, but again, it still fails the license check itself. It seems to complain about p2/orbit/p2.eclipse.plugin/org.gradle.toolingapi/8.9.0.v20240802-0834-s.

[akurtakov]

Would you please open a new PR where automated license issue opening can be verified?

[0dinD]

@akurtakov Sure, I created #3266.