Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target platform to 4.34-I-builds (I20240919-1840). #3279

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Update target platform to 4.34-I-builds (I20240919-1840). #3279

merged 1 commit into from
Sep 21, 2024

Conversation

rgrunber
Copy link
Contributor

@rgrunber rgrunber commented Sep 21, 2024 •
edited
Loading

A comparison of differences in bundles :

ch.qos.logback.core_1.5.0.jar
	ch.qos.logback.core_1.5.7.jar
com.google.guava_33.2.0.jre.jar
	com.google.guava_33.3.0.jre.jar
com.sun.jna_5.14.0.v20231211-1200.jar
	com.sun.jna_5.15.0.v20240915-2000.jar
com.sun.jna.platform_5.14.0.jar
	com.sun.jna.platform_5.15.0.jar
org.apache.ant_1.10.14.v20230922-1200.jar
	org.apache.ant_1.10.15.v20240901-1000.jar
org.apache.commons.cli_1.6.0.jar
	org.apache.commons.cli_1.9.0.jar
org.apache.commons.lang3_3.14.0.jar
	org.apache.commons.lang3_3.16.0.jar
	org.commonmark_0.23.0.v20240917-1000.jar
	org.commonmark-gfm-tables_0.23.0.v20240917-1000.jar
org.eclipse.compare.core_3.8.500.v20240524-2010.jar
	org.eclipse.compare.core_3.8.600.v20240915-0814.jar
org.eclipse.core.contenttype_3.9.500.v20240708-0707.jar
	org.eclipse.core.contenttype_3.9.600.v20240905-1036.jar
org.eclipse.core.resources_3.21.0.v20240805-1607.jar
	org.eclipse.core.resources_3.22.0.v20240916-1025.jar
org.eclipse.debug.core_3.21.500.v20240801-2219.jar
	org.eclipse.debug.core_3.22.0.v20240910-1745.jar
org.eclipse.equinox.preferences_3.11.100.v20240327-0645.jar
	org.eclipse.equinox.preferences_3.11.200.v20240911-1044.jar
org.eclipse.jdt.core_3.39.0.v20240807-1632.jar
	org.eclipse.jdt.core_3.40.0.v20240919-0625.jar
org.eclipse.jdt.core.compiler.batch_3.39.0.v20240820-0604.jar
	org.eclipse.jdt.core.compiler.batch_3.40.0.v20240919-1711.jar
org.eclipse.jdt.core.manipulation_1.21.200.v20240815-2038.jar
	org.eclipse.jdt.core.manipulation_1.21.300.v20240918-0710.jar
org.eclipse.jdt.debug_3.21.500.v20240725-1239.jar
	org.eclipse.jdt.debug_3.21.600.v20240913-0533.jar
org.eclipse.jdt.junit.core_3.13.300.v20240826-1900.jar
	org.eclipse.jdt.junit.core_3.13.400.v20240917-1831.jar
org.eclipse.jdt.launching_3.23.0.v20240822-0459.jar
	org.eclipse.jdt.launching_3.23.50.v20240918-0502.jar
org.eclipse.jdt.ls.core_1.40.0.202409191539.jar
	org.eclipse.jdt.ls.core_1.40.0.202409211754.jar
org.eclipse.jdt.ls.filesystem_1.40.0.202409191539.jar
	org.eclipse.jdt.ls.filesystem_1.40.0.202409211754.jar
org.eclipse.jdt.ls.logback.appender_1.40.0.202409191539.jar
	org.eclipse.jdt.ls.logback.appender_1.40.0.202409211754.jar
org.eclipse.ltk.core.refactoring_3.14.500.v20240702-1521.jar
	org.eclipse.ltk.core.refactoring_3.14.600.v20240905-1133.jar
org.eclipse.osgi_3.21.0.v20240717-2103.jar
	org.eclipse.osgi_3.22.0.v20240917-0858.jar
org.eclipse.search.core_3.16.300.v20240708-0708.jar
	org.eclipse.search.core_3.16.400.v20240905-1151.jar
org.eclipse.text_3.14.100.v20240524-2010.jar
	org.eclipse.text_3.14.200.v20240915-0736.jar
org.eclipse.xtext.xbase.lib_2.34.0.v20240227-0940.jar
	org.eclipse.xtext.xbase.lib_2.36.0.v20240825-0714.jar
org.hamcrest_2.2.0.jar
	org.hamcrest_3.0.0.jar

@rgrunber rgrunber requested a review from snjeza September 21, 2024 00:20
rgrunber
rgrunber commented Sep 21, 2024
View reviewed changes
org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
@@ -27,7 +27,8 @@
<unit id="org.eclipse.jdt.apt.pluggable.core" version="0.0.0"/>
<unit id="org.eclipse.pde.junit.runtime" version="0.0.0" />
<unit id="org.eclipse.jdt.junit4.runtime" version="0.0.0" />
<repository location="https://download.eclipse.org/eclipse/updates/4.33/"/>
<unit id="org.eclipse.jdt.core.manipulation" version="0.0.0" />
Copy link
Contributor Author

@rgrunber rgrunber Sep 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably write a comment about this. Basically, when I was using releases/2024-03 from below, I noticed jdt.core.manipulation would get used from there, even though the one in I-builds was newer. When I bumped to 2024-06, it went away. Bumping to 2024-09 had the issue come back. I decided it makes perfect sense to explicitly require jdt.core.manipulation and that seems to resolve it.

@rgrunber
Update target platform to 4.34-I-builds (I20240919-1840).
2cb9ae9 
- Provide support for Java 23
- Explicitly require o.e.jdt.core.manipulation from platform I-builds

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber
Copy link
Contributor Author

rgrunber commented Sep 21, 2024 •
edited
Loading

retest this please. 403s everywhere 😐 .

Update: First time I've seen it in the build system.

org.junit.ComparisonFailure: expected:<(Object [arg0]) ->> but was:<(Object [t]) ->>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at org.eclipse.jdt.ls.core.internal.handlers.CompletionHandlerTest.testCompletion_Lambda(CompletionHandlerTest.java:3464)

@rgrunber rgrunber merged commit c19da14 into eclipse-jdtls:master Sep 21, 2024
5 of 7 checks passed
@rgrunber rgrunber deleted the update-tp branch September 21, 2024 19:16
@rgrunber rgrunber mentioned this pull request Sep 23, 2024
Merged
rgrunber
rgrunber commented Sep 23, 2024
View reviewed changes
...pse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/managers/MavenProjectImporterTest.java
@@ -370,6 +370,16 @@ public void testJava22Project() throws Exception {
IJavaProject javaProject = JavaCore.create(project);
assertEquals(JavaCore.ENABLED, javaProject.getOption(JavaCore.COMPILER_PB_ENABLE_PREVIEW_FEATURES, false));
assertEquals(JavaCore.IGNORE, javaProject.getOption(JavaCore.COMPILER_PB_REPORT_PREVIEW_FEATURES, false));
assertHasErrors(project, "Preview features enabled at an invalid source release level");
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot @Test . #3281

@rgrunber rgrunber mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snjeza snjeza snjeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide support for Java 23
2 participants
@rgrunber @snjeza