Remove unused extension point

[snjeza]

Fixes #3308

[rgrunber]

This comes from #1507 . Did it ever do anything ? Seemed like you changed the underlying id for it at #1507 (review) .

[snjeza]

Did it ever do anything

No, it didn't. org.eclipse.jdt.ls.core.internal.corext.refactoring.ChangeMethodSignatureRefactoringContribution doesn't exist.
I have faced an exception while checking eclipse-jdtls/eclipse-jdt-core-incubator#755

[rgrunber]

Change is probably fine. I just want to look at how exactly these refactoring contributions end up consumed by JDT UI. My impression is there's some class that loads the extension point registry and contributes them through the context menu, in which case they have no use to us.

[snjeza]

@rgrunber You can check

• https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/348433bcfcd8acf60465822708a22937bf041748/org.eclipse.jdt.core.manipulation/plugin.xml#L67-L69
• Delete large number of files that duplicate files in jdt.core.manipulations #2946

[rgrunber]

I meant :

https://github.com/eclipse-platform/eclipse.platform.ui/blob/c5928bbad22265e3660af18692b9dd9a02413d4e/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/internal/core/refactoring/history/RefactoringContributionManager.java#L164

However, you're right. It's contributed through jdt.core.manipulation now. So even though we use it in

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/RefactorProposalUtility.java

Line 922 in 2e3b770

final IntroduceParameterRefactoring introduceParameterRefactoring = new IntroduceParameterRefactoring(cu, context.getSelectionOffset(), context.getSelectionLength());

into https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/de6bdc93c4b35fcef8c99f646a5da66edc05d476/org.eclipse.jdt.core.manipulation/refactoring/org/eclipse/jdt/internal/corext/refactoring/code/IntroduceParameterRefactoring.java#L571 , it will work without this.