Updating dependencies #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a problem with latest merge - we updated submodules but that did not trigger build for the PR, and after merge the build failed. The problem seems to be a grpcio mismatch, for generating grpc source we use
>=version frompyproject.tomlbut for runtime we use exact version fromrequirements.txtThis gives errors like:
E RuntimeError: The grpc package installed is at version 1.67.1, but the generated code in kuksa/val/v1/val_pb2_grpc.py depends on grpcio>=1.68.0. Please upgrade your grpc module to grpcio>=1.68.0 or downgrade your generated code using grpcio-tools<=1.67.1.Solved in this PR by using a stricter version specifier in both. Mentioned at https://github.com/eclipse-kuksa/kuksa-python-sdk/wiki/Release-Process#update-dependencies
Long term we could possibly get rid of
setup.cfgand possibly alsorequirement*files. We might consider moving to poetry or uv.