Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @ng-bootstrap/ng-bootstrap from 7.0.0 to 18.0.0 #122

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 21, 2025

Bumps @ng-bootstrap/ng-bootstrap from 7.0.0 to 18.0.0.

Release notes

Sourced from @​ng-bootstrap/ng-bootstrap's releases.

18.0.0

This release bumps minimum required versions to Angular 19.0.0.

We have reviewed all components to make sure they are hydratable.
Please note that currently components using i18n require the use of experimental withI18nSupport().
You can learn more about the advantages of hydration in the Angular doc.

Bug Fixes

  • accordion: respect destroyOnHide with OnPush (5b64712)
  • toast: added correct ariaLive values (fc6007e)
  • accordion: fix hydration (3f3173a)

Features

BREAKING CHANGES

ngbAccordionBody has been converted from a Directive into a Component. This is was needed in order to fix accordion hydration while not breaking the syntax.
Note that if you were using a template variable to retrieve the DOM element you will need to query the ElementRef instead of the component .

Concretely, the following code with ng-bootstrap 17.0.2:

@Component({
  standalone: true,
  imports: [NgbAccordionModule],
  template: `
    <div ngbAccordion>
      <div ngbAccordionItem [collapsed]="false">
        <!-- header -->
        <div ngbAccordionCollapse>
          <div ngbAccordionBody #myAccordionBody>
            <ng-template>Actual content</ng-template>
          </div>
      </div>
    </div>
  `
})
export class Example {
  readonly myAccordionBody= viewChild.required<ElementRef>('myAccordionBody');
myScrollingFunction() {
this.myAccordionBody().nativeElement.scrollIntoView();
}
}

needs to be migrated to the following with ng-bootstrap 18.0.0:

@Component({
</tr></table> 

... (truncated)

Changelog

Sourced from @​ng-bootstrap/ng-bootstrap's changelog.

18.0.0 (2024-12-18)

This release bumps minimum required versions to Angular 19.0.0.

We have reviewed all components to make sure they are hydratable.
Please note that currently components using i18n require the use of experimental withI18nSupport().
You can check more about the advantages of hydration in the Angular doc.

Bug Fixes

  • accordion: respect destroyOnHide with OnPush (5b64712)
  • toast: added correct ariaLive values (fc6007e)
  • accordion: fix hydration (3f3173a)

Features

BREAKING CHANGES

  • ngbAccordionBody converted from a Directive into a Component

17.0.1 (2024-08-28)

Hopefully fixes that one datepicker bug with weekday labels.

Also replacing NgZone.onStable() with afterRender()/afterNextRender() internally and using esbuild with zoneless CD for the demo site.

Bug Fixes

  • datepicker: generate weekday labels in correct order (04010d6)
  • datepicker: config not inherited from datepicker-input (db14075), closes #3848
  • datepicker: global config not applied (18919c9), closes #4697
Commits
  • 77b3e17 docs: release 18.0.0
  • 72075a0 docs: release 18
  • 46c00c6 feat(modal): add role option
  • 322f573 docs(datepicker): replace strange quote
  • 98ada07 Update tooltip.ts
  • 5a6aa1e test(accordion): add missing tests
  • 898f9f3 Update .editorconfig
  • ce6014e fix(core)!: restore popperJS preventOverflow function
  • c235781 docs: release 18.0.0-rc.0
  • 7f3d40a docs: accordion recipe in animations guide
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by qderoubaix, a new releaser for @​ng-bootstrap/ng-bootstrap since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@ng-bootstrap/ng-bootstrap](https://github.com/ng-bootstrap/ng-bootstrap) from 7.0.0 to 18.0.0.
- [Release notes](https://github.com/ng-bootstrap/ng-bootstrap/releases)
- [Changelog](https://github.com/ng-bootstrap/ng-bootstrap/blob/master/CHANGELOG.md)
- [Commits](ng-bootstrap/ng-bootstrap@7.0.0...18.0.0)

---
updated-dependencies:
- dependency-name: "@ng-bootstrap/ng-bootstrap"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code major labels Jan 21, 2025
@berezovskyi berezovskyi closed this Feb 8, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 8, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ng-bootstrap/ng-bootstrap-18.0.0 branch February 8, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant