This repository has been archived by the owner on Oct 12, 2021. It is now read-only.
Migrate to the new oslc4j-client #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Berezovskyi <[email protected]>
jamsden
suggested changes
Feb 18, 2019
There was a problem hiding this comment.
Do you need TrsBasicAuthOslcClient subclass of OslcClient? And methods like fetchResourceUsingBaseAuth() don't seem right. Rather the TRS server should use some configuration information to know what authentication to use, and create a ClientBuilder that it passes to OslcClient configured as needed to access the resources using OslcClient directly.
|
Yes, it felt wierd when I was fixing the existing code. I will refactor it as per your suggestions, thanks. |
berezovskyi
added
Status: Changes Requested
Status: Blocked
and removed
Status: Review Needed
labels
Signed-off-by: Andrew Berezovskyi <[email protected]>
Refactored a few things along the way Signed-off-by: Andrew Berezovskyi <[email protected]>
# Conflicts: # pom.xml # src/main/java/org/eclipse/lyo/oslc4j/trs/client/handlers/TRSTaskHandler.java # src/main/java/org/eclipse/lyo/oslc4j/trs/client/util/TrsBasicAuthOslcClient.java
|
@jamsden fixed the subclass issues as you suggested. @jamsden @jadelkhoury please review |
berezovskyi
added
Status: Review Needed
and removed
Status: Blocked
Status: Changes Requested
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
Relies on the client from eclipse-lyo/lyo.client#37