-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to the JITServerUseAOTCache option #1353
Changes to the JITServerUseAOTCache option #1353
Conversation
Jenkins doc stage |
ca2401e
to
6939583
Compare
Jenkins doc stage |
@cjjdespres - I have updated the documents. Please check and let me know if any changes are required. Thanks! |
docs/xxjitservershareromclasses.md
Outdated
@@ -34,7 +34,7 @@ This option enables the JITServer server to share cached ROM classes between JIT | |||
|`-XX:+JITServerShareROMClasses` | Enable | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to have this checked as enabled by default? Then the note could say something about needing to specify the -XX:+JITServerShareROMClasses
explicitly to enable this feature if you've disabled the JITServer AOT cache at the server.
There are also the changes to this option that I described in #1350 (comment), if you'd like to incorporate those into this PR. |
1997d91
to
ff3fcb3
Compare
Jenkins doc stage |
@cjjdespres @mpirvu @pshipton - I have updated the documents. Please check and confirm. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but I have some small suggestions.
eclipse-openj9#1350 `-XX:+JITServerUseAOTCache` is the default setting at the JITServer server Closes eclipse-openj9#1350 Signed-off-by: Sreekala Gopakumar <[email protected]>
ff3fcb3
to
f5c2b0e
Compare
Jenkins doc stage |
@cjjdespres @mpirvu @pshipton - I have made the change. Please check and confirm. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pshipton - Can this be merged? Thanks! |
#1350
-XX:+JITServerUseAOTCache
is the default setting at the JITServer serverCloses #1350
Signed-off-by: Sreekala Gopakumar [email protected]