Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the JITServerUseAOTCache option #1353

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Sreekala-Gopakumar
Copy link
Contributor

#1350

-XX:+JITServerUseAOTCache is the default setting at the JITServer server

Closes #1350
Signed-off-by: Sreekala Gopakumar [email protected]

@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

@cjjdespres - I have updated the documents. Please check and let me know if any changes are required. Thanks!

@@ -34,7 +34,7 @@ This option enables the JITServer server to share cached ROM classes between JIT
|`-XX:+JITServerShareROMClasses` | Enable | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to have this checked as enabled by default? Then the note could say something about needing to specify the -XX:+JITServerShareROMClasses explicitly to enable this feature if you've disabled the JITServer AOT cache at the server.

@cjjdespres
Copy link

There are also the changes to this option that I described in #1350 (comment), if you'd like to incorporate those into this PR.

@Sreekala-Gopakumar Sreekala-Gopakumar force-pushed the 1350JITServerAOT branch 2 times, most recently from 1997d91 to ff3fcb3 Compare June 17, 2024 04:50
@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

@cjjdespres @mpirvu @pshipton - I have updated the documents. Please check and confirm. Thanks!

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I have some small suggestions.

docs/jitserver_tuning.md Outdated Show resolved Hide resolved
docs/jitserver_tuning.md Outdated Show resolved Hide resolved
docs/jitserver_tuning.md Outdated Show resolved Hide resolved
docs/jitserver_tuning.md Outdated Show resolved Hide resolved
docs/version0.46.md Show resolved Hide resolved
docs/xxjitservershareromclasses.md Outdated Show resolved Hide resolved
docs/xxjitserveruseaotcache.md Outdated Show resolved Hide resolved
docs/xxjitserveruseaotcache.md Show resolved Hide resolved
eclipse-openj9#1350

`-XX:+JITServerUseAOTCache` is the default setting at the JITServer server

Closes eclipse-openj9#1350
Signed-off-by: Sreekala Gopakumar <[email protected]>
@Sreekala-Gopakumar
Copy link
Contributor Author

Jenkins doc stage

@Sreekala-Gopakumar
Copy link
Contributor Author

@cjjdespres @mpirvu @pshipton - I have made the change. Please check and confirm. Thanks!

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sreekala-Gopakumar
Copy link
Contributor Author

@pshipton - Can this be merged? Thanks!

@pshipton pshipton merged commit 535fb7f into eclipse-openj9:master Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to the JITServerUseAOTCache and JITServerShareROMClasses options
4 participants