Move argument memory size parsing to j9argscan #10445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlenBadel
force-pushed
the
memsize_parse
branch
from
64f4dde to
956dbc3
Compare
AlenBadel
changed the title
|
Testing on my end. @dmitripivkine May I ask you to take a look? |
AlenBadel
force-pushed
the
memsize_parse
branch
from
da40c64 to
7b5d456
Compare
|
please add |
Agreed. That's also been addressed 644d928c0cfd7557b0a2b6627e644d3948abacfe. |
AlenBadel
force-pushed
the
memsize_parse
branch
from
fcf748c to
1707149
Compare
AlenBadel
force-pushed
the
memsize_parse
branch
3 times, most recently
from
3d41fa0 to
cfcffe2
Compare
|
Seems copyrights for |
Previously, parsing methods were only accessible within the GC. Moving these methods into j9argscan enables them to be used generally by VM, and JIT. Signed-off-by: AlenBadel <[email protected]>
AlenBadel
force-pushed
the
memsize_parse
branch
from
b5a08b3 to
fd15265
Compare
dmitripivkine
approved these changes
Aug 27, 2020
tajila
approved these changes
Aug 27, 2020
|
Sanity test ran clean on my end. |
AlenBadel
changed the title
|
Jenkins test sanity xLinux jdk11 |
|
Jenkins compile all jdk8 |
|
Failure in the x86-64_linux_xl build is not related, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, parsing methods were only accessible within the GC. Moving these methods into j9argscan enables them to be used generally by VM, and JIT.
Signed-off-by: AlenBadel [email protected]