Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add new tests for new options #8820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlenBadel
Copy link
Contributor

Adding tests for -XX:[+/-]UseLargePages, and -XX:LargePageSizeInBytes=<size>.

@gita-omr
Copy link
Contributor

@smlambert I am looking at the changes, but could you please review as well?

@gita-omr
Copy link
Contributor

I think overall coverage is good. I just found the existing naming (before this PR) of the directories a bit confusing:
test/xlp
test/xlpcodecache

Could we rename them into :
test/heappages
test/codecachepages
?

Also not sure if I saw a test for codecache where -Xlp follows -XX options, since -Xlp only partially overrides -XX. But maybe I missed it.

@smlambert
Copy link
Contributor

@AlenBadel - can you resolve the conflict in your PR please (which I think is introduced because your other PR #8025 is now merged), thanks!

@AlenBadel
Copy link
Contributor Author

@smlambert My apologies, this PR will need to wait while #7476 purposes some changes on additional options. Mainly, adding -XX:-UseLargePages. I'll update this PR when everything is straightened out.

@smlambert
Copy link
Contributor

Yes thanks, sounds good @AlenBadel !

@genie-openj9
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants