Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pass-ui] Submission and Deposit optimistic locking #1209

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[pass-ui] Submission and Deposit optimistic locking #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/submission.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export default class SubmissionModel extends Model {
defaultValue: null,
})
submitterEmail;
@attr('number') version;

@belongsTo('user') submitter;
@belongsTo('publication') publication;
Expand Down
4 changes: 3 additions & 1 deletion tests/unit/services/submission-handler-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ module('Unit | Service | submission-handler', (hooks) => {

let submission = EmberObject.create({
id: '0',
version: 3,
submitter: {
id: 'submitter:test-id',
},
Expand All @@ -62,14 +63,15 @@ module('Unit | Service | submission-handler', (hooks) => {
let files = A();
let comment = 'blarg';

assert.expect(13);
assert.expect(14);

return service
.get('submit')
.perform(submission, publication, files, comment)
.then(() => {
assert.false(submission.get('submitted'));
assert.strictEqual(submission.get('submissionStatus'), 'approval-requested');
assert.strictEqual(submission.get('version'), 3);

// web-link repo should not be removed
assert.strictEqual(submission.get('repositories.length'), 2);
Expand Down