Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove routing.transition methods deprecation #1271

Conversation

jaredgalanis
Copy link
Contributor

No description provided.

@jaredgalanis jaredgalanis changed the base branch from main to refactor-remove-ensure-safe-component.string-deprecation May 26, 2024 17:34
@jaredgalanis jaredgalanis changed the title Refactor remove routing.transition methods deprecation refactor: remove routing.transition methods deprecation May 26, 2024
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did some testing of the the ui and all the route transitions still seemed to work.

@jaredgalanis jaredgalanis force-pushed the refactor-remove-ensure-safe-component.string-deprecation branch from b9384aa to 335a384 Compare June 27, 2024 13:45
Base automatically changed from refactor-remove-ensure-safe-component.string-deprecation to main June 27, 2024 13:52
@jaredgalanis
Copy link
Contributor Author

closing in favor of #1275

@jaredgalanis jaredgalanis deleted the refactor-remove-routing.transition-methods-deprecation branch August 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants