Fix lookup of workspace located annotation providers #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
fix_cp_compute_with_imported
branch
2 times, most recently
from
5664fa6 to
db1a17d
Compare
Currently, if a annotation project is part of the workspace (most notable (org.eclipse.pde.api.tools.annotations) it currently does not resolve the binary folders correctly. This fixes the conversion of plugin models to classpath entries by check if a build model is available and if found uses the binary folders as classpath entries instead of the base location.
laeubi
force-pushed
the
fix_cp_compute_with_imported
branch
from
db1a17d to
cf42481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a annotation project is part of the workspace (most notable (org.eclipse.pde.api.tools.annotations) it currently does not resolve the binary folders correctly.
This fixes the conversion of plugin models to classpath entries by check if a build model is available and if found uses the binary folders as classpath entries instead of the base location.