Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Exceptions not actually thrown #1065

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jan 22, 2024

eliminates problem markers and dead code

Copy link

github-actions bot commented Jan 22, 2024

Test Results

   277 files  ±0     277 suites  ±0   53m 27s ⏱️ -42s
 3 498 tests ±0   3 462 ✅ ±0   36 💤 ±0  0 ❌ ±0 
10 625 runs  ±0  10 523 ✅ ±0  102 💤 ±0  0 ❌ ±0 

Results for commit 9613798. ± Comparison against base commit 25a06e7.

♻️ This comment has been updated with latest results.

eliminates problem markers and dead code
@jukzi
Copy link
Contributor Author

jukzi commented Jan 22, 2024

unrelated fail on mac:

Error: Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.5-SNAPSHOT:test (pde-build-tests) on project org.eclipse.pde.build.tests: Installation of IUs [org.eclipse.pde.build.tests, org.eclipse.tycho.surefire.osgibooter, org.eclipse.tycho.surefire.junit4] failed: Call to p2 director application failed with exit code 13. Program arguments were: [-metadataRepository, file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/,file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/targetPlatformRepository/,file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/p2temp/additionalBundles/, -artifactRepository, file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/,file:/resolution-context-artifacts@%252FUsers%252Frunner%252Fwork%252Feclipse.pde%252Feclipse.pde%252Fbuild%252Forg.eclipse.pde.build.tests,file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build/target/,file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/,file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/,file:/Users/runner/.m2/repository/,file:/Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/p2temp/additionalBundles/, -installIU, org.eclipse.pde.build.tests,org.eclipse.tycho.surefire.osgibooter,org.eclipse.tycho.surefire.junit4, -destination, /Users/runner/work/eclipse.pde/eclipse.pde/build/org.eclipse.pde.build.tests/target/sdk-product/Eclipse.app/Contents/Eclipse, -profile, SDKProfile, -profileProperties, org.eclipse.update.install.features=true, -roaming, -p2.os, macosx, -p2.ws, cocoa, -p2.arch, x86_64]. -> [Help 1]

@jukzi jukzi merged commit 5ee72bb into eclipse-pde:master Jan 23, 2024
14 of 15 checks passed
@jukzi jukzi deleted the thrown branch January 23, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants