fix recent javadoc "reference not found" #1393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Can you please move the version bumps into a separate commit as it is our common practice with the usual message Bump version(s) for 4.34 stream so that version bumps are easier to discover in the history and are not reverted in case the actual change is reverted (unlikely in this case).
| @@ -70,7 +70,7 @@ public void testInvalidBundleContainers() throws Exception { | |||
| * Tests that if we find a bundle with a bad or missing manifest when | |||
| * resolving we create the correct status. | |||
| * | |||
| * @see TargetBundle.STATUS_INVALID_MANIFEST | |||
| * @see org.eclipse.pde.core.target.TargetBundle#STATUS_INVALID_MANIFEST | |||
There was a problem hiding this comment.
The FQN is not necessary since the type org.eclipse.pde.core.target.TargetBundle is already imported.
Suggested change
| * @see org.eclipse.pde.core.target.TargetBundle#STATUS_INVALID_MANIFEST | |
| * @see TargetBundle#STATUS_INVALID_MANIFEST |
|
I have included the commit of this PR into #1400 and applied the requested changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1392