Fix more warnings in pde.ui and pde.ds.ui #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
fix-more-warnings
branch
from
c75876e to
6de0b7a
Compare
Test Results 285 files 285 suites 53m 24s ⏱️ Results for commit b1c6fcb. ♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
fix-more-warnings
branch
3 times, most recently
from
14075cc to
ccc4990
Compare
HannesWell
commented
Sep 8, 2024
| vmArgs = AssertionVMArg.enableAssertInArgString(vmArgs); | ||
| if (vmArgs.length() > 0) | ||
| configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_ARGUMENTS, vmArgs); | ||
| @SuppressWarnings("restriction") |
There was a problem hiding this comment.
This entire src_samples source folder somehow seems to be related to something like sample.properties files.
Does anybody know anything about that?
It also seems to be associated to a org.eclipse.sdk.samples provided via the site
http://www.eclipse.org/pde/samples/site.xml
But I have never heard of this and assume it's outdated if it is usable at all?
@merks, @iloveeclipse or @akurtakov do you know anything about that or can this entire source folder be removed?
And apply minor clean-ups in ExtensionsSection. The branch in DSFileWizardPage.getProject(Object) that checks if the passed object is a ClassPathContainer seems to be possible anymore. Suppress warnings that cannot be resolved.
HannesWell
force-pushed
the
fix-more-warnings
branch
from
ccc4990 to
b1c6fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And apply minor clean-ups in ExtensionsSection.
The branch in
DSFileWizardPage.getProject(Object)that checks if the passed object is aClassPathContainerseems to be possible anymore.In general creating OSGI Service Components through the UI is a quite uncommon nowdays since one can simply use the Decalarative service component annotations.