Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force qualifier update in org.eclipse.pde.api.tools #1467

Closed

Conversation

HannesWell
Copy link
Member

to fix comparator errors/warnings in verification builds:

 [WARNING] MavenProject: org.eclipse.pde:org.eclipse.pde.api.tools:1.3.600-SNAPSHOT @ /home/jenkins/agent/workspace/eclipse.pde_master/apitools/org.eclipse.pde.api.tools/.polyglot.META-INF: baseline and build artifacts have same version but different contents
    no-classifier: different
       org/eclipse/pde/api/tools/internal/builder/IncrementalApiBuilder$ResourceDeltaVisitor.class: different
       org/eclipse/pde/api/tools/internal/util/Signatures.class: different

But since the I-build does not complain I fear it's a configuration difference and it will be a reoccurring issue.

@laeubi
Copy link
Contributor

laeubi commented Nov 10, 2024

But since the I-build does not complain I fear it's a configuration difference and it will be a reoccurring issue.

This is usually because one needs to deploy/use a more recent compiler see for example:

Copy link

github-actions bot commented Nov 10, 2024

Test Results

   285 files  ±0     285 suites  ±0   57m 32s ⏱️ + 3m 54s
 3 586 tests ±0   3 508 ✅  - 2   76 💤 ±0  0 ❌ ±0  2 🔥 +2 
10 950 runs  ±0  10 717 ✅  - 2  231 💤 ±0  0 ❌ ±0  2 🔥 +2 

For more details on these errors, see this check.

Results for commit 45d01d3. ± Comparison against base commit ef694eb.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member Author

But since the I-build does not complain I fear it's a configuration difference and it will be a reoccurring issue.

This is usually because one needs to deploy/use a more recent compiler see for example:

* [Class file diff in validation builds eclipse-platform/eclipse.platform.releng.aggregator#1960](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/1960)

Thanks for that hint. That makes sense and fits to #1461.

I updated this PR to verify this in PDE, but if it's fixing it it should be done in the parent-pom as in the linked issue.

@HannesWell
Copy link
Member Author

This test was successful and the generalization is done in eclipse-platform/eclipse.platform.releng.aggregator#2538.

@HannesWell HannesWell closed this Nov 13, 2024
@HannesWell HannesWell deleted the api.tools-qualifier-update branch November 13, 2024 22:45
@HannesWell HannesWell restored the api.tools-qualifier-update branch November 14, 2024 19:20
@HannesWell HannesWell reopened this Nov 14, 2024
@HannesWell HannesWell force-pushed the api.tools-qualifier-update branch from b7c709a to e333c6d Compare November 14, 2024 19:21
@HannesWell
Copy link
Member Author

Reopened this to try out if a range works well for the cbi-ecj-version.

@HannesWell HannesWell force-pushed the api.tools-qualifier-update branch from e333c6d to 45d01d3 Compare November 14, 2024 19:29
@HannesWell HannesWell closed this Nov 17, 2024
@HannesWell HannesWell deleted the api.tools-qualifier-update branch November 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants