Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Launching] Don't add -Djava.security.manager=allow for Java-24 or later #1516

Merged
merged 3 commits into from
Dec 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Launching] Don't add -Djava.security.manager=allow for Java-24 or later
Since Java-24 the security-manager cannot be used anymore and launching
a Java-24 VM fails to launch if the VM-argument
'-Djava.security.manager=allow' is specified.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2623
  • Loading branch information
HannesWell committed Dec 13, 2024
commit cf2d437067187344dcfb5d26e36eccbe0d462209
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ private String[] updateVMArgumentWithAdditionalArguments(String[] args, IVMInsta
if (isEclipseBundleGreaterThanVersion(4, 24) // Don't add allow flags for eclipse before 4.24
&& vmInstall instanceof AbstractVMInstall install) {
String vmver = install.getJavaVersion();
if (vmver != null && JavaCore.compareJavaVersions(vmver, JavaCore.VERSION_17) >= 0) {
if (vmver != null && JavaCore.compareJavaVersions(vmver, JavaCore.VERSION_17) >= 0 && JavaCore.compareJavaVersions(vmver, JavaCore.VERSION_23) <= 0) {
VMHelper.addNewArgument(arguments, "-Djava.security.manager", "allow"); //$NON-NLS-1$ //$NON-NLS-2$
}
}
Expand Down
Loading