Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the "version update" button in target editor #1518

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 14, 2024

I see constant confusion about what the buttons in the target editor do and therefore like to suggest we use a different term, my proposal is to use "Upgrade" instead of "Update" (similar to apt-get update versus apt-get (dist-)upgrade).

Even though the file is (possibly) updated this often seem to indicate to users that they can update a stale state instead, while now we better express that one version is upgraded to a newer one.

Before

grafik

After

grafik

Copy link

Test Results

   285 files  +  6     285 suites  +6   48m 27s ⏱️ + 4m 3s
 3 586 tests ±  0   3 510 ✅ +  1   76 💤 ± 0  0 ❌  - 1 
10 950 runs  +194  10 719 ✅ +166  231 💤 +29  0 ❌  - 1 

Results for commit 524c72b. ± Comparison against base commit ba8fc7f.

@HannesWell
Copy link
Member

I see constant confusion about what the buttons in the target editor do and therefore like to suggest we use a different term, my proposal is to use "Upgrade" instead of "Update" (similar to apt-get update versus apt-get (dist-)upgrade).

Even though the file is (possibly) updated this often seem to indicate to users that they can update a stale state instead, while now we better express that one version is upgraded to a newer one.

While I think it won't solve all confusion, it could definitely help a bit. Especially the latter confusion should be solved. Ultimately I can just recommend and recommend to recommend to read the tool-tips.

@laeubi laeubi merged commit 2c1860a into eclipse-pde:master Dec 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants