Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the project component api baseline to lookup the component #1539

Closed

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 29, 2024

Currently the api-tools heavily rely on a common shared "workspace baseline" this baseline can be disposed and then changes at any time. While this can work in an IDE context, it makes it quite hard for other tools to use this standalone because there is no way to reliable use an alternative mean of "workspace baseline".

This now changes the ProjectApiDescription in a way where the baseline is passed in from the project component and it only fall back to the static singleton if the baseline is disposed.

laeubi and others added 2 commits December 29, 2024 13:53
Currently the api-tools heavily rely on a common shared "workspace
baseline" this baseline can be disposed and then changes at any time.
While this can work in an IDE context, it makes it quite hard for other
tools to use this standalone because there is no way to reliable use an
alternative mean of "workspace baseline".

This now changes the ProjectApiDescription in a way where the baseline
is passed in from the project component and it only fall back to the
static singleton if the baseline is disposed.
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7fc3bcd49c79a5783a5c4a5c9d60f91e1df3368a Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Sun, 29 Dec 2024 12:57:37 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
index 7fbad0b9c6..73b6266936 100644
--- a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
+++ b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.api.tools;singleton:=true
-Bundle-Version: 1.3.600.qualifier
+Bundle-Version: 1.3.700.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

Test Results

   285 files  ±0     285 suites  ±0   45m 57s ⏱️ - 1m 2s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 3a2bac8. ± Comparison against base commit 2f6b308.

@laeubi laeubi marked this pull request as draft December 29, 2024 13:48
@laeubi
Copy link
Contributor Author

laeubi commented Dec 29, 2024

One problem is org.eclipse.pde.api.tools.internal.model.ProjectComponent.createLocalApiDescription() want to cache API descriptions for a project.

@laeubi laeubi closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants