Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a digest to generate the API baseline target location #1545

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 31, 2024

Currently the ApiModelFactory#generateTargetLocation only uses the sequence number for its location what is unreliable as many aspects can influence the actual "change" in a target.

This now uses a SHA-1 hash over the actual target content to produce a location that is unique for a given target content.

Lets see if that works better...

laeubi and others added 2 commits December 31, 2024 13:41
Currently the ApiModelFactory#generateTargetLocation only uses the
sequence number for its location what is unreliable as many aspects can
influence the actual "change" in a target.

This now uses a SHA-1 hash over the actual target content to produce a
location that is unique for a given target content.
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 5e6a01f3de1e9066fa7fc75fc515f429bef3375b Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Tue, 31 Dec 2024 12:45:41 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
index 7fbad0b9c6..73b6266936 100644
--- a/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
+++ b/apitools/org.eclipse.pde.api.tools/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.api.tools;singleton:=true
-Bundle-Version: 1.3.600.qualifier
+Bundle-Version: 1.3.700.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

Test Results

   285 files     285 suites   48m 30s ⏱️
 3 586 tests  3 510 ✅  76 💤 0 ❌
10 950 runs  10 719 ✅ 231 💤 0 ❌

Results for commit a307e3f.

@laeubi laeubi merged commit 3dfbf59 into eclipse-pde:master Dec 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants