Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for build/org.eclipse.pde.build #1643

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Mar 6, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

build/org.eclipse.pde.build/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 5f8b13ca7808728a2ca7e606a9d4e566946e27dd Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Sun, 9 Mar 2025 02:29:27 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/build/org.eclipse.pde.build/META-INF/MANIFEST.MF b/build/org.eclipse.pde.build/META-INF/MANIFEST.MF
index fed4bd6ac6..e3b7492d4f 100644
--- a/build/org.eclipse.pde.build/META-INF/MANIFEST.MF
+++ b/build/org.eclipse.pde.build/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.build;singleton:=true
-Bundle-Version: 3.12.700.qualifier
+Bundle-Version: 3.12.800.qualifier
 Bundle-ClassPath: pdebuild.jar
 Bundle-Activator: org.eclipse.pde.internal.build.BuildActivator
 Bundle-Vendor: %providerName
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   285 files  +  6     285 suites  +6   50m 11s ⏱️ + 3m 46s
 3 608 tests ±  0   3 532 ✅ +  2   76 💤  -  1  0 ❌  - 1 
11 016 runs  +194  10 785 ✅ +167  231 💤 +28  0 ❌  - 1 

Results for commit 249cd76. ± Comparison against base commit c7d99fd.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/build/org.eclipse.pde.build branch from 9797690 to 3d8cd6e Compare March 6, 2025 13:39
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/build/org.eclipse.pde.build branch from 3d8cd6e to cbb1670 Compare March 7, 2025 02:36
@laeubi laeubi force-pushed the clean-code/build/org.eclipse.pde.build branch from 7b0bddc to 3f8b623 Compare March 7, 2025 06:06
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/build/org.eclipse.pde.build branch from 3f8b623 to c53e7b3 Compare March 8, 2025 02:22
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/build/org.eclipse.pde.build branch from d07b53d to 85758ac Compare March 9, 2025 02:24
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@laeubi laeubi merged commit 3e1aead into master Mar 9, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/build/org.eclipse.pde.build branch March 9, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants