Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ui/org.eclipse.pde.ui.tests #1662

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Mar 6, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
ui/org.eclipse.pde.ui.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From dbc0fd710eeba2bff4044f352fdd19f0e981c31e Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Fri, 7 Mar 2025 03:33:34 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
index 44a16d1ff4..2382eddf8d 100644
--- a/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: PDE JUnit Tests
 Bundle-SymbolicName: org.eclipse.pde.ui.tests; singleton:=true
-Bundle-Version: 3.13.0.qualifier
+Bundle-Version: 3.13.100.qualifier
 Bundle-ClassPath: tests.jar
 Bundle-Vendor: Eclipse.org
 Require-Bundle: org.eclipse.pde.ui,
diff --git a/ui/org.eclipse.pde.ui.tests/pom.xml b/ui/org.eclipse.pde.ui.tests/pom.xml
index cef87944ff..cbdbf4a0c9 100644
--- a/ui/org.eclipse.pde.ui.tests/pom.xml
+++ b/ui/org.eclipse.pde.ui.tests/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.pde.ui.tests</artifactId>
-  <version>3.13.0-SNAPSHOT</version>
+  <version>3.13.100-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   285 files  ±0     285 suites  ±0   48m 11s ⏱️ +13s
 3 608 tests ±0   3 532 ✅ ±0   76 💤 ±0  0 ❌ ±0 
11 016 runs  ±0  10 785 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 851504b. ± Comparison against base commit b6ca5ab.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/ui/org.eclipse.pde.ui.tests branch from f6e349f to bc4ec7b Compare March 6, 2025 15:00
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.ui.tests branch from bc4ec7b to baecbd6 Compare March 7, 2025 03:26
@laeubi laeubi force-pushed the clean-code/ui/org.eclipse.pde.ui.tests branch from 3341bc2 to 851504b Compare March 7, 2025 06:08
@laeubi laeubi merged commit fd56735 into master Mar 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants