Use the actual system-packages from the JVM for Product/Site export #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2022
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Aug 11, 2022
With eclipse-pde#279 and eclipse-pde#284 the users of those profiles were changed to use better ways to find the available system-packages of a Java version.
iloveeclipse
previously requested changes
Aug 12, 2022
build/org.eclipse.pde.build/src/org/eclipse/pde/internal/build/site/PDEState.java
Outdated
Show resolved
Hide resolved
HannesWell
force-pushed
the
fix194ForBuild
branch
from
4c78fec to
9241aca
Compare
HannesWell
dismissed
iloveeclipse’s stale review
The requested change has been implemented.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Aug 13, 2022
With eclipse-pde#279 and eclipse-pde#284 the users of those profiles were changed to use better ways to find the available system-packages of a Java version.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Aug 14, 2022
With eclipse-pde#279 and eclipse-pde#284 the users of those profiles were changed to use better ways to find the available system-packages of a Java version.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Aug 16, 2022
With eclipse-pde#279 and eclipse-pde#284 the users of those profiles were changed to use better ways to find the available system-packages of a Java version.
|
Sorry for my late answer, I was on holiday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #221 (comment) #194 can also occur when exporting Products.
This applies the same fix to PDE-build. In my little test-case that worked.
Since pde.core depends on pde.build I had to copy the code from
TargetPlatformHelperto PDE build. Looking at other places this is not the first time the dependency issue was solved like that.Additionally this applies a minor shortcut for
TargetPlatformHelper.querySystemPackages()