Deprecate ApiFileGenerationApplication #422
Conversation
|
Did we also replace ApiAnalysisApplication with Tycho or only the API generation part? |
|
Could this application log a message? An application is usually not consumed via API but using the launcher with the applicationId. Some consumers would still not be informed if we just deprecate the API. |
Not yet, only API generation has a good and complete replacement at the moment. |
Eclipse platform migrated to Tycho for generating the API baseline.
Yon also also add the generation to your Tycho build.
Also platform is not using this application anymore it is now deprecated
and may be deleted in the future-
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-apitools-plugin</artifactId>
<version>${tycho.version}</version>
<executions>
<execution>
<id>generate</id>
<goals>
<goal>generate</goal>
</goals>
<configuration>
<skip>${skipAPIDescription}</skip>
<projectName>${project.artifactId}_${qualifiedVersion}</projectName>
laeubi marked this conversation as resolved.
</configuration>
</execution>
</executions>
</plugin>
I added an error output message, which should be visible to any user. |
There was a problem hiding this comment.
I approve that.
In general, I approve moving as much of Ant support out of PDE. If someone wants to ensure Ant build support, it would better fit in a separate project (I remember it used to be Eclipse Athena providing that, but since it dies long ago, there is apparently not so much interest).
|
I just wanted to note that this is actually not ant task the application was just previously called by ant (but you could have done this with other things as well). |
This is work in progress see |
Great. Once this is done, we should review which of the Ant Tasks from the org.eclipse.pde.api.tools.internal.tasks package are not used anymore by platform and deprecated these. |
|
Thanks for the correction @laeubi ; I was mistaken with the other conversation. I'm then a bit skeptical that removing applications is a good idea. The benefit of applications is that they can easily be integrated with any tool: bash, Gradle, Tycho, Ant... without further integration effort; this seems important as we don't want to lock consumers of API Tools to 1 particular build tool or 1 particular process. |
There was a problem hiding this comment.
Looks good to me.
And while it is right that applications give great flexibility, my guess is that there are not many, If no usages at all without Tycho. I don't think there are many people that build Eclipse Plugins without Tycho and therefore I think this applies to this app top.
But if I'm wrong the deprecation notice will hopefully encourage other users to let ist know.
Eclipse platform migrated to Tycho for generating the API baseline. Yon also also add the generation to your Tycho build. Also platform is not using this application anymore it is now deprecated and may be deleted in the future-
org.eclipse.tycho tycho-apitools-plugin ${tycho.version} generate generate ${skipAPIDescription} ${project.artifactId}_${qualifiedVersion} laeubi marked this conversation as resolved.