-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add osgi-repository target location type #692
Add osgi-repository target location type #692
Conversation
ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/messages.properties
Outdated
Show resolved
Hide resolved
...i/src/org/eclipse/pde/internal/ui/shared/target/RepositoryBundleContainerAdapterFactory.java
Outdated
Show resolved
Hide resolved
...i/src/org/eclipse/pde/internal/ui/shared/target/RepositoryBundleContainerAdapterFactory.java
Show resolved
Hide resolved
...i/src/org/eclipse/pde/internal/ui/shared/target/RepositoryBundleContainerAdapterFactory.java
Outdated
Show resolved
Hide resolved
location = RemoteTargetHandle.getEffectiveUri(furiLocation.getText().trim()); | ||
} catch (CoreException e) { | ||
setMessage(e.getMessage(), IMessageProvider.WARNING); | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this catch block return true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use variables in the location and depending on the used ones this might fail while you create the location (e.g. the variable points to a project selection or similar), still I want to allow people to complete even though you then only get a very basic location you don't need to hand-code them in the XML source.
IMessageProvider.ERROR); | ||
return true; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error is issued but the result is true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is similar to the other case, e.g. the user might want to point to a file that is (not yet) existing but should still be able to complete the wizard.
I understand that this are maybe strange cases but I don't block the user in such cases from finish the dialog.
I really appreciate the fact that PDE's compatibility with and support of OSGi standard components is improved piece by piece. Nice work! |
I can only second that. @laeubi if you want, I can offer you to review this when I'm back from vacation mid of next week. |
@HannesWell my plan was to finish this before M2 (Friday, August 4, 2023 if I read the calendar right) so it can go into this release, as this is really a standalone feature I think we can improve it later on if there are any issues discovered quite easy. |
d92145f
to
af94538
Compare
Jenkins succeed, Platform specific testfailures are documented here: |
The deadline for the Platform's m2 contribution came and went July 28th: https://wiki.eclipse.org/Category:SimRel-2023-09 The build for that contribution is always due on a Friday, one week before the milestone is complete, is generally done two days before that, i.e., on a Wednesday. As others have mentioned, this looks cool and I don't see any good reason not to aim for including this for m3! |
I think I gave up on understanding the calendar :-D So what should happen in the period of
So this would be from 08/04 - 08/18 ?!? |
My favorite part of the whole process is where EMF has to contribute its build to the Platform 7 days before the contribution deadline and eventually in the RC weeks there is overlap between that an SimRel's previous contribution... 😱 The Platform decided to opt out of a heavy-weight freeze/testing period for m2, so it all happened with little fanfare. Yes, the Platform will want to produce a build for August 16 and will want no new APIs after that point. The "open gap" here is/was from the M1 freeze week to August 16 or roughly 6 weeks. Keep up the good work. 👍 |
af94538
to
3e25f96
Compare
If no further comments I plan to merge this in the next days. |
3e25f96
to
8a9d79b
Compare
The OSGi Specification defines a XML format for representing a repository as defined in "132 Repository Service Specification" that allows to hold "Resources" with requirements and capabilities. Such a repository usually contains a set of bundles and is very similar to what we have today with P2 updatesites, to improve interfacing of PDE with such repositories this adds a new target location type "Repository" where content can be used as usual.
8a9d79b
to
f870248
Compare
The OSGi Specification defines a XML format for representing a repository as defined in "132 Repository Service Specification" that allows to hold "Resources" with requirements and capabilities.
Such a repository usually contains a set of bundles and is very similar to what we have today with P2 updatesites, to improve interfacing of PDE with such repositories this adds a new target location type "Repository" where content can be used as usual.