Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startlevel & Autostart values are displaying in Run/Debug config #649 #784

Conversation

Dinesh0723
Copy link
Contributor

Disposing the editor in tree viewer.

Fixes #649

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Test Results

     270 files  +       6       270 suites  +6   1h 16m 30s ⏱️ + 23m 32s
  3 327 tests  -        1    3 297 ✔️ ±       0  30 💤 ±  0  0  - 1 
10 278 runs  +2 721  10 188 ✔️ +2 698  90 💤 +24  0  - 1 

Results for commit e98b727. ± Comparison against base commit d551a60.

This pull request removes 1 test.
AllPDETests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@Dinesh0723 Dinesh0723 force-pushed the Issue/649_Start_level_&_Auto_start_values_are_displaying_in_Run/_Debug_configurations_in_Plug-ins_tab branch from 4fdf16d to ce4f9e9 Compare October 26, 2023 06:45
@alshamams
Copy link
Contributor

I have verified the changes made, and they are working. 👍

@gireeshpunathil
Copy link
Contributor

@Dinesh0723 - could you please sign ECA? https://www.eclipse.org/legal/ECA.php

@Dinesh0723
Copy link
Contributor Author

@Dinesh0723 - could you please sign ECA? https://www.eclipse.org/legal/ECA.php

I have already signed the ECA form.
2023-10-27_09h53_39
.

@iloveeclipse
Copy link
Member

I have already signed the ECA form.

But you used different mail for that:

Committer did not have a signed ECA on file. (130960675+Dinesh0723@us*rs DOT noreply DOT github DOT com)

Please use email in commit that was used for ECA.

@gireeshpunathil
Copy link
Contributor

most probably your git shell / eclipse egit is not configured with your email.
git config --global user.email <your email>
git config --global user.name <your name>

and then push again probably should fix this.

@Dinesh0723 Dinesh0723 force-pushed the Issue/649_Start_level_&_Auto_start_values_are_displaying_in_Run/_Debug_configurations_in_Plug-ins_tab branch from ce4f9e9 to 1b48d0b Compare October 31, 2023 04:37
Dinesh0723 and others added 21 commits November 6, 2023 18:12
The exception is an attempt to shed some light in the real cause of the
problem that's causing some tests fail and it simply replaces an obscure
NPE that's happening anyway.

Contributes to eclipse-pde#554
Currently javadoc is not generated as part of the build making javadoc
errors hard to discover.
It is allowed to not specify any schema provider in that case no
additional search is performed.

Fix eclipse-platform/.github#167
"Plug-ins" is the term which is also used if you switch your product to
be plug-in based.
Instead of "The following list of locations will be used to collect
plug-ins for this target definition." we use "Locations used to collect
plug-ins and features for this target definition." which is
shorter and correct. Old text was missing the features.
The commit fixes OSGi plugins (that have been created using standard
OSGi framework with 'Generate OSGi metadata automatically' feature) not
being displayed in the export dialog box. This happens because an OSGi
project has a pde.bnd file, unlike the eclipse plugins, which has
build.properties. Therefore the previous behaviour was to check for the
presence of a build.properties file for validating a plugin project.
This assumption breaks with the new type.
This commit removes some of the unused attributes of plugin element,
 which are redundant and are never read from a feature.xml file:
 install-size, fragment, download size and unpack attributes.
Uses 1.0.0.qualifier a version for a newly created product configuration
file, as this is required for a pomless Tycho build and other PDE
artifacts are also using this number.

Fixes eclipse-pde#851
Mixed products can not be exported from the workspace (at the moment).
In order to avoid later errors, disable the export action in the
Product-Editor for mixed products.

Fixes eclipse-pde#825
Currently we rely on the Manifest to discover all required items but
that do not work for items that are not referenced inside the manifest.

This handles the BND Buildpath/Testpath as if it was part of the
traditional Secondary Dependencies.

Fix eclipse-pde#777
The PDE Product Editor used to add a 'fragment' attribute to plugin
elements in *.product files, but the attribute is unused for a long
time.

Relates to eclipse-equinox/p2#378
fedejeanne and others added 22 commits November 7, 2023 10:24
This reverts commit 62815c8.
This reverts commit 5a81c02.
@gireeshpunathil
Copy link
Contributor

@Dinesh0723 - I see you have bit of tough time pushing changes. let me try to help you here.

  • git fetch upstream (assuming you have configured this remote as upstream)
  • git rebase upstream/master
  • in case of any conflicts resolve those manually
  • once all are clean, just do git log and see your one single commit is comfortably sitting on top of upstream/master
  • at that point you push to origin: git push origin <the pr's branch name> (btw, your branch name is pretty long, you can skim through other PRs to see a common naming convention for PR branches)

while all the above steps are for command line, I guess similar menu items will be there in eclipse edit as well.

feel free to ask if you get into trouble in any step!

@Dinesh0723
Copy link
Contributor Author

Dinesh0723 commented Nov 23, 2023

@gireeshpunathil , This PR is messed up with multiple commits. I have tried the above steps as you mentioned that didn't worked. so, I am planning to close this PR and create a new PR link for this issue,
#931

@Dinesh0723 Dinesh0723 closed this Nov 23, 2023
@Dinesh0723 Dinesh0723 deleted the Issue/649_Start_level_&_Auto_start_values_are_displaying_in_Run/_Debug_configurations_in_Plug-ins_tab branch November 23, 2023 09:25
@gireeshpunathil
Copy link
Contributor

sorry @Dinesh0723 that this happened. But don't worry at all, I can help you resolve this through a quick zoom or Webex call, or if it is easy for you to do it in a new PR then go for that; whichever is convenient to you, let me know!

@Dinesh0723
Copy link
Contributor Author

sorry @Dinesh0723 that this happened. But don't worry at all, I can help you resolve this through a quick zoom or Webex call, or if it is easy for you to do it in a new PR then go for that; whichever is convenient to you, let me know!

Thanks for your support. I have already created a new PR (#931). I will contact you in future, if I am stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start level & Auto start values are displaying in Run/ Debug configurations in Plug-ins tab