-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Startlevel & Autostart values are displaying in Run/Debug config #649 #784
Conversation
Test Results 270 files + 6 270 suites +6 1h 16m 30s ⏱️ + 23m 32s Results for commit e98b727. ± Comparison against base commit d551a60. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
4fdf16d
to
ce4f9e9
Compare
I have verified the changes made, and they are working. 👍 |
@Dinesh0723 - could you please sign ECA? https://www.eclipse.org/legal/ECA.php |
|
But you used different mail for that:
Please use email in commit that was used for ECA. |
most probably your git shell / eclipse egit is not configured with your email. and then push again probably should fix this. |
…e-pde#649 Disposing the editor in tree viewer. Fixes eclipse-pde#649
ce4f9e9
to
1b48d0b
Compare
…e-pde#649 Disposing the editor in tree viewer. Fixes eclipse-pde#649
The exception is an attempt to shed some light in the real cause of the problem that's causing some tests fail and it simply replaces an obscure NPE that's happening anyway. Contributes to eclipse-pde#554
Currently javadoc is not generated as part of the build making javadoc errors hard to discover.
It is allowed to not specify any schema provider in that case no additional search is performed. Fix eclipse-platform/.github#167
"Plug-ins" is the term which is also used if you switch your product to be plug-in based.
Instead of "The following list of locations will be used to collect plug-ins for this target definition." we use "Locations used to collect plug-ins and features for this target definition." which is shorter and correct. Old text was missing the features.
The commit fixes OSGi plugins (that have been created using standard OSGi framework with 'Generate OSGi metadata automatically' feature) not being displayed in the export dialog box. This happens because an OSGi project has a pde.bnd file, unlike the eclipse plugins, which has build.properties. Therefore the previous behaviour was to check for the presence of a build.properties file for validating a plugin project. This assumption breaks with the new type.
This commit removes some of the unused attributes of plugin element, which are redundant and are never read from a feature.xml file: install-size, fragment, download size and unpack attributes.
Uses 1.0.0.qualifier a version for a newly created product configuration file, as this is required for a pomless Tycho build and other PDE artifacts are also using this number. Fixes eclipse-pde#851
Mixed products can not be exported from the workspace (at the moment). In order to avoid later errors, disable the export action in the Product-Editor for mixed products. Fixes eclipse-pde#825
Apply the result of eclipse-pde#730 to PDE.
Currently we rely on the Manifest to discover all required items but that do not work for items that are not referenced inside the manifest. This handles the BND Buildpath/Testpath as if it was part of the traditional Secondary Dependencies. Fix eclipse-pde#777
The PDE Product Editor used to add a 'fragment' attribute to plugin elements in *.product files, but the attribute is unused for a long time. Relates to eclipse-equinox/p2#378
This reverts commit 62815c8.
This reverts commit 8438cad.
…esolution" This reverts commit ab010d1.
… products" This reverts commit 3cff2bc.
This reverts commit 9a7e6b8.
…tainer" This reverts commit a72ca92.
This reverts commit 9d57222.
This reverts commit 3095365.
This reverts commit ac18e86.
This reverts commit 4be9857.
This reverts commit 5a81c02.
This reverts commit 1d99771.
…inimalState" This reverts commit 443b6e8.
This reverts commit ba728d3.
This reverts commit abd385b.
This reverts commit da891d4.
…ection" This reverts commit 5bb0823.
This reverts commit a75a979.
This reverts commit 823eb1e.
This reverts commit 65cb5f7.
…t installed" This reverts commit 30ac4d2.
@Dinesh0723 - I see you have bit of tough time pushing changes. let me try to help you here.
while all the above steps are for command line, I guess similar menu items will be there in eclipse edit as well. feel free to ask if you get into trouble in any step! |
@gireeshpunathil , This PR is messed up with multiple commits. I have tried the above steps as you mentioned that didn't worked. so, I am planning to close this PR and create a new PR link for this issue, |
sorry @Dinesh0723 that this happened. But don't worry at all, I can help you resolve this through a quick zoom or Webex call, or if it is easy for you to do it in a new PR then go for that; whichever is convenient to you, let me know! |
Thanks for your support. I have already created a new PR (#931). I will contact you in future, if I am stuck. |
Disposing the editor in tree viewer.
Fixes #649