Support setting the bundleroot for manifest generated projects #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 273 files + 6 273 suites +6 1h 6m 10s ⏱️ + 14m 52s For more details on these failures, see this check. Results for commit 5ca3233. ± Comparison against base commit 99eeff9. ♻️ This comment has been updated with latest results. |
laeubi
force-pushed
the
manifest_at_root
branch
2 times, most recently
from
e2d7c7d to
0bb9795
Compare
laeubi
force-pushed
the
manifest_at_root
branch
from
0bb9795 to
6d0a83a
Compare
Draft
5 tasks
Currently we have only the option to set the bundleroot to a different folder (what the will become the outputfolder). In some cases one might want to set the bundle root also to the project root. This now adds special handling for the case where bundle root != output folder. Fix eclipse-pde#803
laeubi
force-pushed
the
manifest_at_root
branch
from
6d0a83a to
5ca3233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have only the option to set the bundleroot to a different folder (what the will become the outputfolder). In some cases one might want to set the bundle root also to the project root.
This now adds special handling for the case where bundle root != output folder.
Fix #803
@merks if you like to try this out do the follwoing:
.settings/org.eclipse.jdt.core.prefsBUNDLE_ROOT_PATH=META-INF/MANIFEST.MFcreated at the root of the project for your for your convenience and comfortPlease note that currently there is no UI and I would not recomment such setup but it should address your concerns and allow a soft migration path.