Use the generic editor as the source editor for bnd instructions

[laeubi]

Currently a plain TextEditor is used, but the ExtensionBasedTextEditor is much more powerful.

@mickaelistria I was able to use ExtensionBasedTextEditor now and register the completion proposals via extension registry so it seems to work at the basics, can you take a look if it looks sane or I'm doing anything wrong here/not recommended?

Relates to #701

[github-actions]

Test Results

   258 files   -        6     258 suites   - 6   50m 30s ⏱️ - 1m 9s
3 328 tests ±       0  3 295 ✔️  -        2  30 💤 ±  0  3 ❌ +2 
4 856 runs   - 2 701  4 811 ✔️  - 2 679  42 💤  - 24  3 ❌ +2 

For more details on these failures, see this check.

Results for commit 0961862. ± Comparison against base commit b62ea08.

[mickaelistria]

While I didn't spot anything obviously wrong, I recommend you compare it with how the TargetEditor is implemented. It also does use the generic editor in a tab. Not sure which approach is better for this case.

[gireeshpunathil]

will this have any implications (positive or negative) on the (pending) auto-completion feature? or is it independent of the editor type? (nvm, I did not see #817 that was already landed.)

[laeubi]

will this have any implications (positive or negative) on the (pending) auto-completion feature? or is it independent of the editor type?

Depends on what specific auto-completion feature you refer to, this has two purposes:

1. GenericEditor can be extended even by other (non pde) plugins
2. There is ongoing discussions about having a BND LanguageServer so I hope if we get this working to integrate the bnd instructions source page with the language server to get autocompletion/validation and so on in an PDE independent way what can be shared across tools (PDE/BNDtools/VSCode/Theia/...)

[laeubi]

I recommend you compare it with how the TargetEditor is implemented. It also does use the generic editor in a tab

Good pointer, I checked this and it only slightly differs a bit as the Target editor has a bit more "control", so for the ManifestEdior things are a bit abstracted why it seems that I need to implement IFormPage ...