Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only single editor when open plain BND files #819

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Oct 25, 2023

Currently the manifest editor shows an error when one opens a plain bnd file. This is because no "manifest first" parts are found and the bnd form page is only added for pde.bnd files.

This now fixes the issue by making manifest-first files completely optional and show a plain bnd editor instead in case of only a bnd file.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Test Results

     270 files  +       6       270 suites  +6   1h 3m 12s ⏱️ + 12m 33s
  3 327 tests  -        1    3 296 ✔️  -        1  30 💤 ±  0  1 ±0 
10 278 runs  +2 721  10 187 ✔️ +2 697  90 💤 +24  1 ±0 

For more details on these failures, see this check.

Results for commit 4e2a932. ± Comparison against base commit b3d1df7.

This pull request removes 1 test.
AllPDETests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 26, 2023

@laeubi laeubi force-pushed the support_open_detached_bnd branch 2 times, most recently from c0b8a2f to 03ccb5f Compare October 27, 2023 12:03
Currently the manifest editor shows an error when one opens a plain bnd
file. This is because no "manifest first" parts are found and the bnd
form page is only added for pde.bnd files.

This now fixes the issue by making manifest-first files completely
optional and show a plain bnd editor instead in case of only a bnd file.
@laeubi laeubi force-pushed the support_open_detached_bnd branch from 03ccb5f to 4e2a932 Compare October 27, 2023 15:47
@laeubi laeubi merged commit 0aa2d7e into eclipse-pde:master Oct 28, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant