Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reproducer test case for issue #874 #957

Closed
wants to merge 0 commits into from

Conversation

ptziegler
Copy link
Contributor

@ptziegler ptziegler commented Nov 30, 2023

Consider the following situation: The SimRel 2023-12 repository contains FasterXML Jackson bundles with version 2.16.0, with the exception of one bundle that is still in 2.15.3.

In order to ensure that all those bundles have the same version, the one in 2.15.3 is also contributed via Maven Central (imitated by a local directory) in 2.16.0.

Trying to resolve this target definition fails with: No repository found containing:
osgi.bundle,
com.fasterxml.jackson.module.jackson-module-jaxb-annotations,
2.16.0

Meaning PDE knows that there is a newer version available, it just doesn't know where to find it...
Note that one can work around this problem by explicitly adding the missing bundle to the IU location.

@ptziegler
Copy link
Contributor Author

Cannot invoke "org.eclipse.equinox.internal.p2.repository.Transport.download(java.net.URI, java.io.OutputStream, org.eclipse.core.runtime.IProgressMonitor)" because the return value of "org.eclipse.equinox.internal.p2.repository.helpers.AbstractRepositoryManager.getTransport()" is null

Of course the test doesn't work during the Jenkins run... 😠

@laeubi
Copy link
Contributor

laeubi commented Dec 1, 2023

Of course the test doesn't work during the Jenkins run... 😠

it could be you need an additional test requirement for the ECF transport.

@ptziegler
Copy link
Contributor Author

Not sure why GitHub decided to close this one but in the end, I don't think this test would've gone anywhere...

Several test are disabled during the Jenkins build via PDETestCase.assumeRunningInStandaloneEclipseSDK() for similar reasons. So I assume it's simply not possible to connect to a "real" repository during the test.
The pull request is continued via #962

@laeubi
Copy link
Contributor

laeubi commented Dec 2, 2023

@ptziegler this can happen if if you push a commit that is even with master (e.g. you did not push any changes).

Several test are disabled during the Jenkins build via PDETestCase.assumeRunningInStandaloneEclipseSDK() for similar reasons. So I assume it's simply not possible to connect to a "real" repository during the test.

Actually it should be possible, maybe we should rethink that but of course it could slow down the build a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants