Skip to content

Commit

Permalink
[Build] Define all smoke-test parameters in job definition again
Browse files Browse the repository at this point in the history
Defining them only in the pipeline has the effect that the jobs forgets
it's parameter each time the job-configuration is recreated by the
seed-job and thus the subsequent first execution of the smoke-test fails
because it has 'forgotten' it's parameters and has to re-discover them
on the first pipeline execution again.

Follow-up on
#2637
  • Loading branch information
HannesWell committed Dec 12, 2024
1 parent db10b04 commit abda769
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
16 changes: 16 additions & 0 deletions JenkinsJobs/SmokeTests/FOLDER.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@ folder('SmokeTests') {

pipelineJob('SmokeTests/Start-smoke-tests'){
description('Start all smoke tests for the Eclipse SDK')
// Define parameters in job configuration to make them already available in the very first build
parameters {
stringParam {
name('buildId')
description('Build Id to test (such as I20240611-1800, N20120716-0800).')
trim(true)
}
}
parameters {
stringParam {
name('testsToRun')
defaultValue('ui')
description('This can be any ant target from https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/production/testScripts/configuration/sdk.tests/testScripts/test.xml')
trim(true)
}
}
definition {
cpsScm {
lightweight(true)
Expand Down
4 changes: 0 additions & 4 deletions JenkinsJobs/SmokeTests/StartSmokeTests.jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ spec:
'''
}
}
parameters {
string(name: 'buildId', description: 'Build Id to test (such as I20240611-1800, N20120716-0800).')
string(name: 'testsToRun', defaultValue: 'ui', description: 'This can be any ant target from https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/production/testScripts/configuration/sdk.tests/testScripts/test.xml')
}
stages {
stage('Trigger tests'){
matrix {
Expand Down

0 comments on commit abda769

Please sign in to comment.