Skip to content

Commit

Permalink
[GH] Explicitly specify mvn-toolchain-id for setup JDKs to match BREEs
Browse files Browse the repository at this point in the history
The toolchains.xml generated by the setup-java GitHub action has '8' as
'version' value for the Java-1.8 JDK and therefore the
tycho-compiler-plugin does not match it when has 'useJDK=BREE'
configured for a Plugin with BREE JavaSE-1.8.

Therefore explicitly set the 'id' of each jdk-toolchain to match the
corresponding BREE identifier so that the tycho-compiler-plugin can
find it via this secondary way.
  • Loading branch information
HannesWell committed Sep 25, 2023
1 parent bf4b588 commit e16a757
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/mavenBuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ jobs:
8
11
17
mvn-toolchain-id: |
JavaSE-1.8
JavaSE-11
JavaSE-17
distribution: 'temurin'
cache: maven
- name: Set up Maven
Expand Down

0 comments on commit e16a757

Please sign in to comment.