Unanticipated comparator errors in I20230922-1800

[iloveeclipse]

See

• https://download.eclipse.org/eclipse/downloads/drops4/I20230922-1800/testResults.php
• https://download.eclipse.org/eclipse/downloads/drops4/I20230922-1800/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

Comparator differences from current build
	/home/jenkins/agent/workspace/Builds/I-build-4.30/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/siteDir/eclipse/downloads/drops4/I20230922-1800
compared to reference repo at 
	https://download.eclipse.org/eclipse/updates/4.30-I-builds

1.  eclipse.jdt.core/org.eclipse.jdt.core.compiler.batch/pom.xml
   no-classifier: different
      org/eclipse/jdt/internal/compiler/ast/TypeReference.class: different
      org/eclipse/jdt/internal/compiler/parser/Parser.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

2.  equinox/bundles/org.eclipse.equinox.security.ui/.polyglot.META-INF
   no-classifier: different
      org/eclipse/equinox/internal/security/ui/storage/TabAdvanced.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

I assume that

1. is regression from Revert "Remove Y-builds reference in pom.xml (#1414)" eclipse-jdt/eclipse.jdt.core#1417
2. is regression from use stronger cipher for secure storage eclipse-equinox/equinox#285

but I haven't checked if that assumption is correct. Going to investigate.

[iloveeclipse]

@akurtakov : I don't see a diff generated for JDT in the https://download.eclipse.org/eclipse/downloads/drops4/I20230922-1800/buildlogs/comparatorlogs/artifactcomparisons.zip

Could it be, the new compiler.batch bundle need to be made "known" in some build scripts that generate the zip file with diff?

[iloveeclipse]

I don't see any changes in JDT that would explain diff on except the suspicious pom file changes switching eclipse-p2-repo.url to Y-builds in eclipse-jdt/eclipse.jdt.core#1417 and eclipse-jdt/eclipse.jdt.debug#316.

But I assume we still have to touch batch compiler. Will push a PR in a moment.

[HannesWell]

That's really forensic work.

[iloveeclipse]

In org.eclipse.jdt.internal.compiler.parser.Parser we have lambdas (we had issues with lambda order generated differently for same source), but not in org.eclipse.jdt.internal.compiler.ast.TypeReference.

Interestingly, zip doesn't contain diffs for both classes bytecode, and also comparing class files from different ecj jars I also see no difference.

So I guess the JDT problem reported could be really related to eclipse-p2-repo.url pointing to Y-builds repo.

[iloveeclipse]

OK, I've merged everything needed, going to start new I Build.

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.30/34/

[iloveeclipse]

Fixed with https://download.eclipse.org/eclipse/downloads/drops4/I20230923-0520/