Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove Y-builds reference in pom.xml (#1414)" #1417

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

jjohnstn
Copy link
Contributor

@jjohnstn jjohnstn commented Sep 22, 2023

This reverts commit e501dd8.

What it does

How to test

Author checklist

@jjohnstn jjohnstn merged commit 30ca4c3 into eclipse-jdt:master Sep 22, 2023
7 checks passed
@akurtakov
Copy link
Contributor

Jeff, this is wrong. Skipping API analysis is terrible idea and running verification against another stream even worse!

@akurtakov
Copy link
Contributor

@iloveeclipse Would you please look into this one? Same thing in jdt.debug (eclipse-jdt/eclipse.jdt.debug#316). Jeff told me that he reverted this one due to API error after removal which is most likely a legitimate API issue.

@iloveeclipse
Copy link
Member

@iloveeclipse Would you please look into this one? Same thing in jdt.debug (eclipse-jdt/eclipse.jdt.debug#316). Jeff told me that he reverted this one due to API error after removal which is most likely a legitimate API issue.

On my list, see eclipse-platform/eclipse.platform.releng.aggregator#1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants