Use o.e.platform.ide when building the platform-source zip #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
replaceRemovedProducts
branch
from
53e915e to
4fb3852
Compare
|
I don't think this build tests what you have changed. E.g., look at this one: So it's probably more expedient to merge this and start and I-Build which definitely will test these changes... |
Yes definitely not the change in the platformrepo.xml. But the for the removal of the rcp/pom.xml I would like confirmation that it is not referenced from some remote place. At least the direct parent does not include a |
... in order to replace the removed org.eclipse.platform.sdk product definition. Additionally remove the unused org.eclipse.platform.releng.tychoeclipsebuilder/rcp/pom.xml. From the history it looks like it was introduced as pom for the now also removed rcp.product. Follow-up on eclipse-platform#1235
HannesWell
force-pushed
the
replaceRemovedProducts
branch
from
4fb3852 to
c5a2815
Compare
|
Build succeeded. I'm about to kick off a new I-build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to replace the removed org.eclipse.platform.sdk
Additionally remove the unused
org.eclipse.platform.releng.tychoeclipsebuilder/rcp/pom.xml. From the history it looks like it was introduced as pom fro the also removed rcp.product.
Follow-up on
#1235