Move common build arguments to maven.config and remove unnecessary #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property 'project.build.sourceEncoding' is already defined in the eclipse-platform-parent/pom.xml used as parent for all modules, thus it is not necessary to explicitly add it in the Jenkinsfile. Moving the definition of the 'aggregatorBuild' property to the maven.config simplifies local builds because then the property does not have to be declared.
|
@akurtakov what do you think? |
|
Looks good to me. It's not once or twice that issues haven't been called due to aggregatorBuild not being used locally and thus extra resolving from I-builds repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property 'project.build.sourceEncoding' is already defined in the eclipse-platform-parent/pom.xml used as parent for all modules, thus it is not necessary to explicitly add it in the Jenkinsfile.
Moving the definition of the 'aggregatorBuild' property to the maven.config simplifies local builds because then the property does not have to be declared.