Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jakarta.inject-api / jakarta.annotation-api to isv build #1436

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Oct 12, 2023

No description provided.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 12, 2023

/request-license-review

@github-actions
Copy link
Contributor

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/6493011823

@merks
Copy link
Contributor

merks commented Oct 12, 2023

@laeubi

FYI, ignore the license problem. It's unrelated to your change.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 12, 2023

CI is fine so lets go for it...

@laeubi laeubi merged commit c54ca74 into eclipse-platform:master Oct 12, 2023
1 of 2 checks passed
@akurtakov
Copy link
Member

This is still not fixed as the the same symbolic name jakarta.annotation-api is used for both versions which confuses the handcrafted script.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 13, 2023

This is still not fixed as the the same symbolic name jakarta.annotation-api is used for both versions which confuses the handcrafted script.

Do you mean Tycho extra requirements or can you reference the script in question?

@laeubi
Copy link
Contributor Author

laeubi commented Oct 13, 2023

@akurtakov another question: Can we somehow see this error in this build here as well?

@mickaelistria
Copy link
Contributor

@akurtakov
Copy link
Member

I haven't looked enough into how can we make the jenkins build fail if javadoc build fails if this is the question.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 13, 2023

@laeubi
Copy link
Contributor Author

laeubi commented Oct 13, 2023

@mickaelistria I mean what ever fails and needs fixing here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants