Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jakarta.servlet-api, javax.servlet.jsp-api, javax.el-api to target #1462

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

merks
Copy link
Contributor

@merks merks commented Oct 24, 2023

Some smaller products have narrower dependencies that are satisfied by these, even if the SDK itself doesn't need/use them.

#1361

Some smaller products have narrower dependencies that are satisfied by
these, even if the SDK itself doesn't need/use them.

eclipse-platform#1361
@merks
Copy link
Contributor Author

merks commented Oct 24, 2023

@iloveeclipse

I think given the long cycle time here, we should just merge this and do an I-Build immediately. Do you agree?

@iloveeclipse
Copy link
Member

Yes please

@merks merks merged commit ed12ae0 into eclipse-platform:master Oct 24, 2023
2 checks passed
@merks merks deleted the issue-1361-tp branch October 24, 2023 10:39
@merks
Copy link
Contributor Author

merks commented Oct 24, 2023

Okay done. I started this build:

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.30/82/

@iloveeclipse
Copy link
Member

Build succeeded, but we have again issues generating javadoc...

../../../equinox/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/ExtendedHttpService.java:18: error: package javax.servlet does not exist
import javax.servlet.Filter;

etc ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants