Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bouncycastle to 1.78.1 #1986

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Apr 19, 2024

No description provided.

@merks
Copy link
Contributor Author

merks commented Apr 19, 2024

The build fails like this:

 Error:  Cannot resolve project dependencies:
Error:    Software being installed: org.eclipse.jdt.feature.group 3.19.500.qualifier
Error:    Missing requirement: bcpg 1.78.1 requires 'java.package; org.bouncycastle.asn1.cryptlib [1.78.1,1.79.0)' but it could not be found
Error:    Cannot satisfy dependency: org.eclipse.equinox.p2.engine 2.10.100.qualifier depends on: java.package; org.bouncycastle.openpgp 1.65.0
Error:    Cannot satisfy dependency: org.eclipse.jdt.debug.ui 3.13.400.qualifier depends on: osgi.bundle; org.eclipse.ui.ide [3.5.0,4.0.0)
Error:    Cannot satisfy dependency: org.eclipse.jdt.feature.group 3.19.500.qualifier depends on: org.eclipse.equinox.p2.iu; org.eclipse.jdt.debug.ui 0.0.0
Error:    Cannot satisfy dependency: org.eclipse.ui.ide 3.22.200.qualifier depends on: osgi.bundle; org.eclipse.equinox.p2.engine [2.8.0,3.0.0)

So we need to add the bundle that provides the org.bouncycastle.asn1.cryptlib package, i.e., bcutil-jdk18on.

Because bcpg 1.78.1 requires java.package org.bouncycastle.asn1.cryptlib
[1.78.1,1.79.0)' which is provided by bcutil, bcutil-jdk18on must be
added to the target platform
@merks merks force-pushed the pr-bouncycastle-1.78.1 branch from 4590264 to 6ca4054 Compare April 19, 2024 09:32
@merks
Copy link
Contributor Author

merks commented Apr 19, 2024

@iloveeclipse @akurtakov @tomaswolf

FYI, it appears necessary to add a dependency on bcutil-jdk18on to use the 1.78.1 version of bcpg.

Note that for testing purposes, I created an installation with only 1.78.1 versions and that resolved/installed fine:

image

@merks
Copy link
Contributor Author

merks commented Apr 19, 2024

I will assume later today that no one has any concerns about me merging these changes.

@akurtakov
Copy link
Member

I have no concerns.

@iloveeclipse
Copy link
Member

Latest Egit still works on this platform ?

@merks
Copy link
Contributor Author

merks commented Apr 19, 2024

Yes, I was able to clone:

image

I'm not sure that exercises the bouncycastle functionality; I'm not sure what does. I tried updating their target platform to run the tests. That worked, but I had to add a package import to eliminate a class not found exception:

image

My understanding is that this is only used to to GPG signing of commits, which is not something the Eclipse SDK development process uses.

@merks merks merged commit 1f0ecd1 into eclipse-platform:master Apr 20, 2024
4 checks passed
@merks merks deleted the pr-bouncycastle-1.78.1 branch April 20, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants