Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding *.product file for update release. #2583

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

MohananRahul
Copy link
Contributor

Product files also need to be updated.

@akurtakov
Copy link
Member

Is tycho-versions-plugin updating product files when run locally?

@laeubi
Copy link
Contributor

laeubi commented Nov 27, 2024

If we include products then actually also features should be included, but also here we should check that they actually gets a version change (as the version needs to match the release) but the title is a bit misleading as it talks about prepare release (that only updates the parent), but you actually change the update release workflow.

@akurtakov akurtakov changed the title Adding Product file for prepare release. Adding *.product file for update release. Dec 5, 2024
@akurtakov
Copy link
Member

I tested locally and product files are updated:

[INFO] --- tycho-versions:4.0.10:set-version (default-cli) @ org.eclipse.rt.osgistarterkit.product ---
[INFO] Making changes in /home/akurtakov/git/eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder/equinox.starterkit.product
[INFO]   pom.xml//project/version: 4.35.0-SNAPSHOT => 5.0.0-SNAPSHOT
[INFO]   EclipseRTOSGiStarterKit.product//product/@version: 4.35.0.qualifier => 5.0.0.qualifier
[INFO] Making changes in /home/akurtakov/git/eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder
[INFO] Making changes in /home/akurtakov/git/eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder/equinox-sdk
[INFO] Making changes in /home/akurtakov/git/eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests
[INFO] Making changes in /home/akurtakov/git/eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository
[INFO] Making changes in /home/akurtakov/git/eclipse.platform.releng.aggregator/eclipse-platform-parent
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

@akurtakov
Copy link
Member

Merging. Let's see one more bit automated next release.

@akurtakov akurtakov merged commit b2d6bdd into eclipse-platform:master Dec 10, 2024
4 checks passed
@MohananRahul MohananRahul deleted the UpRel branch December 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants