Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update previous release version to 4.34 GA across build scripts #2608

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Update previous release version to 4.34 GA across build scripts #2608

merged 1 commit into from
Nov 29, 2024
+31 −31

Conversation

MohananRahul
Copy link
Contributor

Fix #2607

@MohananRahul
Copy link
Contributor Author

Merging this PR as verification builds will not verify.

@MohananRahul MohananRahul merged commit 0e4fb78 into eclipse-platform:master Nov 29, 2024
3 of 4 checks passed
@MohananRahul MohananRahul deleted the Fix2607 branch November 29, 2024 16:36
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request Nov 30, 2024
@HannesWell
Revert "Update previous release version to 4.34 GA across build scrip…
08aeae3 
…ts (eclipse-platform#2608)"

This reverts commit 0e4fb78.
@HannesWell
Copy link
Member

Isn't this applied too early? 4.34 is not yet released.
As far as I can tell, this currently breaks the I-build (even though it currently seems to be more severely broken at a infrastructure level).

@MohananRahul
Copy link
Contributor Author

Isn't this applied too early? 4.34 is not yet released. As far as I can tell, this currently breaks the I-build (even though it currently seems to be more severely broken at a infrastructure level).

The GA has already been promoted to SimRel, and it’s available—it's just not yet visible.

HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request Nov 30, 2024
@HannesWell
Complete update of previous release version to 4.34 GA in build scripts
b76621b 
This part was missing in
eclipse-platform#2608
@HannesWell HannesWell mentioned this pull request Nov 30, 2024
Merged
@HannesWell
Copy link
Member

Isn't this applied too early? 4.34 is not yet released. As far as I can tell, this currently breaks the I-build (even though it currently seems to be more severely broken at a infrastructure level).

The GA has already been promoted to SimRel, and it’s available—it's just not yet visible.

Indeed. The actual problem was that one property was not updated accordingly in this change. Did it now in

HannesWell added a commit that referenced this pull request Nov 30, 2024
@HannesWell
Complete update of previous release version to 4.34 GA in build scripts
b666509 
This part was missing in
#2608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update previous release version to 4.34 GA across build scripts
2 participants
@MohananRahul @HannesWell