Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Remove now unused 'cbi-jdt-repo.url' from mavenproperties #2622

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[Build] Remove now unused 'cbi-jdt-repo.url' from mavenproperties #2622

merged 1 commit into from
Dec 3, 2024

Conversation

HannesWell
Copy link
Member

Keeping that variable fails the I-build because is is not used and not defined anymore since #2538.

This should fix the failure of 4.35 I-Build: I20241202-1800:

 BUILD FAILED
 /home/jenkins/agent/workspace/Builds/I-build-4.35/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/gitCache/
  eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder/eclipse/buildScripts/eclipse_compare.xml:29:
Property cbi-jdt-repo.url was circularly defined.

@HannesWell
[Build] Remove now unused 'cbi-jdt-repo.url' from mavenproperties
97a44ac 
Keeping that variable fails the I-build because is is not used and not
defined anymore since:
eclipse-platform#2538
@HannesWell
Copy link
Member Author

Submitting this now (the verification build does not test this) and start another I-build.

@HannesWell HannesWell merged commit 6b31d45 into eclipse-platform:master Dec 3, 2024
2 of 4 checks passed
@HannesWell HannesWell deleted the remove-unused-variable branch December 3, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HannesWell